Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix typo #1216

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Docs: fix typo #1216

merged 2 commits into from
Nov 14, 2024

Conversation

remiposo
Copy link
Contributor

Removed the unnecessary > before concat.

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 10:31am

@igalklebanov igalklebanov added the documentation Improvements or additions to documentation label Nov 14, 2024
@igalklebanov
Copy link
Member

Hey 👋

The examples on the site are actually auto-generated from JSDocs comments. In order to fix this example, you'd have to go to the source @ https://github.com/kysely-org/kysely/blob/master/src/query-builder/insert-query-builder.ts#L205

@remiposo
Copy link
Contributor Author

remiposo commented Nov 14, 2024

@igalklebanov

Thank you for your feedback!
I corrected the JSDocs comments and then ran npm run script:generate-site-examples.

Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@igalklebanov igalklebanov merged commit 5e03f61 into kysely-org:master Nov 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants