add returning support in MERGE queries.
#1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalklebanov
added
api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
force-pushed
the
pg-merge-returning
branch
from
6c67c82 to
6f5bd45
Compare
igalklebanov
force-pushed
the
pg-merge-returning
branch
from
6f5bd45 to
15c3659
Compare
igalklebanov
force-pushed
the
v0.28
branch
2 times, most recently
from
b2b78db to
ae5cb1e
Compare
igalklebanov
force-pushed
the
pg-merge-returning
branch
from
b247f1f to
ce43779
Compare
igalklebanov
force-pushed
the
pg-merge-returning
branch
from
ce43779 to
01f3621
Compare
igalklebanov
force-pushed
the
pg-merge-returning
branch
from
01f3621 to
e8cff03
Compare
igalklebanov
force-pushed
the
pg-merge-returning
branch
from
e8cff03 to
6aedec0
Compare
igalklebanov
force-pushed
the
pg-merge-returning
branch
from
6aedec0 to
11ebc19
Compare
|
Open in Stackblitz • kysely_koa_example commit: |
add returning compilation. add MultiTableReturningInterface. add returning/returningAll @ MergeQueryBuilder. add returning @ transformer. add returning handling @ execute. fix returningAll not allowing source table in single variant. remove multi table variant returningAll. add unit tests. allow overriding which expression builder is created in select parsers. support merge_action() unit tests. Discard changes to src/parser/expression-parser.ts Discard changes to src/parser/select-parser.ts extract `mergeAction` to helper instead. .. typings tests. fix returningAll() typeings test case. Discard changes to src/parser/merge-parser.ts
igalklebanov
force-pushed
the
pg-merge-returning
branch
from
11ebc19 to
c61be00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
closes #1169.
As of PostgreSQL 17,
MERGEqueries now havereturningclause support.returning/returningAlltoMERGE.MultiTableReturningInterface, enforce it acrossDeleteQueryBuilder,UpdateQueryBuilderandMERGEbuilders. Why? the existingReturningInterfacedoesn't have thereturningAll(tables)methods, andINSERTqueries are the only ones that don't supportreturning table.*.merge_action()in a type-safe and aliasable way - a PostgreSQL helper function was found to be the lightest solution. Expanding theExpressionBuilderlocally (only forreturning) witheb.mergeAction()was also tested, but was adding way more changes. I think that with documentation we could nullify the worse discoverability.