Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated TraversedJSONPathBuilder.$castTo and .$notNull to support chaining with .as() #1139

Conversation

cassus
Copy link
Contributor

@cassus cassus commented Sep 5, 2024

closes #1138

i hope :)

TODO

  • add test

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 6:30pm

@aphex
Copy link

aphex commented Sep 5, 2024

👀

@cassus cassus changed the title TraversedJSONPathBuilder.$castTo and .$notNull should return TraversedJSONPathBuilder TraversedJSONPathBuilder.$castTo and .$notNull should be aliasable with .as Sep 7, 2024
@cassus cassus changed the title TraversedJSONPathBuilder.$castTo and .$notNull should be aliasable with .as Updated TraversedJSONPathBuilder.$castTo and .$notNull to support chaining with .as() Sep 7, 2024
@cassus cassus marked this pull request as ready for review September 7, 2024 18:30
@cassus
Copy link
Contributor Author

cassus commented Sep 14, 2024

I'm ready for your review @aphex

@aphex
Copy link

aphex commented Sep 15, 2024

@cassus likely not me you're looking for, I am just a lowly interested party on this one haha. Ran into the same issue and wanted to see it cleared up. Your tests seem to cover the situation I am struggling with, so 👍 from me, but sadly I have no power here :)

Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@igalklebanov igalklebanov added bug Something isn't working api Related to library's API labels Sep 15, 2024
@igalklebanov igalklebanov merged commit 88d0b8a into kysely-org:master Sep 15, 2024
12 checks passed
@cassus cassus deleted the cassus/TraversedJSONPathBuilder-cast-return branch September 15, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to library's API bug Something isn't working
Projects
None yet
3 participants