Skip to content

Commit

Permalink
chore: fix workflows. (#8)
Browse files Browse the repository at this point in the history
  • Loading branch information
igalklebanov authored Nov 24, 2023
1 parent 903b418 commit 4010b60
Show file tree
Hide file tree
Showing 11 changed files with 1,707 additions and 1,096 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [16.x, 18.x, 20.x]
fail-fast: false

services:
singlestore:
image: ghcr.io/singlestore-labs/singlestoredb-dev
image: ghcr.io/singlestore-labs/singlestoredb-dev:0.2.11
ports:
- 3306:3306
- 8080:8080
Expand All @@ -38,9 +38,9 @@ jobs:
node-version: ${{ matrix.node-version }}

- name: Install pnpm
uses: pnpm/action-setup@v2.2.2
uses: pnpm/action-setup@v2
with:
version: 7
version: 8
run_install: false

- name: Get pnpm store directory
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
auto-install-peers=true
31 changes: 31 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Contributing

## Testing

### Preqrequisites

1. Docker installed and running.
2. pnpm v8 installed globally and `pnpm install` ran.
3. A SingleStore Self-Managed license key.
4. Run `pnpm exec playwright install`

### Running Tests

1. Start a SingleStore container by running `SINGLESTORE_LICENSE=<your_singlestore_license_key> docker-compose up --force-recreate` in your terminal and wait for it to finish starting up.
2. Clone the repository.
3. Run `pnpm test`.

## Submitting changes

1. Fork the repository.
2. Create a branch from `main` with a descriptive name.
3. Make your changes.
4. Test your changes.
5. Commit your changes.
6. Push your changes to your fork.
7. Create a pull request to the `main` branch of the repository.
8. Set `SINGLESTORE_LICENSE` to your SingleStore license key in the GitHub Actions secrets.
9. Make sure the tests pass in the pull request.
10. Wait for a maintainer to review your pull request.
11. If the maintainer requests changes, make the changes and push them to your fork.
12. Once the maintainer approves your pull request, they will merge it into the `main` branch.
4 changes: 2 additions & 2 deletions compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ services:
image: ghcr.io/singlestore-labs/singlestoredb-dev
environment:
ROOT_PASSWORD: test
SINGLESTORE_LICENSE: <singlestore_license>
SINGLESTORE_LICENSE: $SINGLESTORE_LICENSE
ports:
- '3306:3306'
- '8080:8080'
- '9000:9000'
volumes:
- ${PWD}/scripts/init.sql:/init.sql
- ./scripts/init.sql:/init.sql
8 changes: 4 additions & 4 deletions examples/cjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
"start": "ts-node ./src/index.ts"
},
"dependencies": {
"kysely": "^0.23.4",
"kysely": "^0.26.3",
"kysely-singlestore": "file:../..",
"undici": "^5.10.0"
"undici": "^5.28.0"
},
"devDependencies": {
"@types/node": "^18.7.23",
"@types/node": "^18.18.13",
"ts-node": "^10.9.1",
"typescript": "^4.8.3"
"typescript": "^5.3.2"
}
}
8 changes: 4 additions & 4 deletions examples/esm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
"start": "ts-node-esm ./src/index.ts"
},
"dependencies": {
"kysely": "^0.23.4",
"kysely": "^0.26.3",
"kysely-singlestore": "file:../..",
"undici": "^5.10.0"
"undici": "^5.28.0"
},
"devDependencies": {
"@types/node": "^18.7.23",
"@types/node": "^18.18.13",
"ts-node": "^10.9.1",
"typescript": "^4.8.3"
"typescript": "^5.3.2"
}
}
53 changes: 27 additions & 26 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"fmt:check": "prettier --check .",
"lint": "eslint src --ext .ts",
"prepack": "pnpm run lint && pnpm run build",
"test": "pnpm run build && pnpm run test:nodejs && pnpm run test:browser && pnpm run test:deno",
"test:browser": "esbuild tests/browser/main.ts --bundle --outfile=tests/browser/bundle.js && node tests/browser/test.js",
"test:deno": "pnpm run test:deno:local && pnpm run test:deno:cdn",
"test:deno:cdn": "deno run --allow-net --import-map=tests/deno/import_map.json tests/deno/cdn.test.ts",
Expand All @@ -41,36 +42,36 @@
"type-check": "tsc --noEmit"
},
"peerDependencies": {
"kysely": ">= 0.7.8 < 1"
"kysely": ">= 0.26.3 < 1"
},
"devDependencies": {
"@tsconfig/node16": "^1.0.3",
"@types/chai": "^4.3.3",
"@types/chai-as-promised": "^7.1.5",
"@types/mocha": "^10.0.0",
"@types/node": "^16",
"@typescript-eslint/eslint-plugin": "^5.38.0",
"@typescript-eslint/parser": "^5.38.0",
"chai": "^4.3.6",
"@tsconfig/node18": "^18.2.2",
"@types/chai": "^4.3.11",
"@types/chai-as-promised": "^7.1.8",
"@types/mocha": "^10.0.6",
"@types/node": "^18.18.13",
"@typescript-eslint/eslint-plugin": "^6.12.0",
"@typescript-eslint/parser": "^6.12.0",
"chai": "^4.3.10",
"chai-as-promised": "^7.1.1",
"date-fns": "^2.29.3",
"esbuild": "^0.15.10",
"esbuild-runner": "^2.2.1",
"eslint": "^8.24.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-prettier": "^4.2.1",
"kysely": "^0.23.4",
"mocha": "^10.0.0",
"mysql2": "^2.3.3",
"date-fns": "^2.30.0",
"esbuild": "^0.19.7",
"esbuild-runner": "^2.2.2",
"eslint": "^8.54.0",
"eslint-config-prettier": "^9.0.0",
"eslint-plugin-import": "^2.29.0",
"eslint-plugin-prettier": "^5.0.1",
"kysely": "^0.26.3",
"mocha": "^10.2.0",
"mysql2": "^3.6.5",
"node-fetch": "^2",
"playwright": "^1.29.2",
"prettier": "^2.7.1",
"prettier-plugin-organize-imports": "^3.1.1",
"prettier-plugin-pkg": "^0.17.1",
"tsup": "^6.2.3",
"typescript": "^4.8.4",
"undici": "^5.10.0"
"playwright": "^1.40.0",
"prettier": "^3.1.0",
"prettier-plugin-organize-imports": "^3.2.4",
"prettier-plugin-pkg": "^0.18.0",
"tsup": "^8.0.1",
"typescript": "^5.3.2",
"undici": "^5.28.0"
},
"sideEffects": false
}
Loading

0 comments on commit 4010b60

Please sign in to comment.