Feature/143 #1
Merged
Feature/143 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds the method `addDefaultParam($templateName, $key, $value)` to `TemplateRendererInterface`; define a TEMPLATE_ALL constant. Replaces `addParameters()`. - Renames `AddParametersTrait` to `DefaultParamsTrait` - Renames `$templateParams` to `$defaultParams` - Renames `addParameters()` to `addDefaultParam()` - Updates PlatesRenderer to the interface changes. - Modifies Twig and ZendView renderers to use the new trait. - Wrote tests for the behavior for each renderer.
- `s/$template/$renderer/` throughout new tests.
weierophinney
force-pushed
the
feature/143
branch
from
5f72509 to
5e6561a
Compare
|
Fixed the conflicts; ready to review and merge now, @kynx . |
- due to invalid variable reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch rebases against develop, and incorporates the feedback I provided in zendframework#143.
However, you have new commits on your branch since I started my work, so I may need to rebase against your code again to make this work.