Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge remote-tracking branch 'origin/main' into 46-feature-mod-goqu-t… #47

Merged
merged 27 commits into from
Oct 4, 2024

Conversation

kynmh69
Copy link
Owner

@kynmh69 kynmh69 commented Sep 29, 2024

…o-gorm

プルリクエストのタイトル

概要

  • このプルリクエストの目的と主な変更点を簡潔に説明してください。

issueの番号

変更内容

  • 具体的な変更点をリスト形式で明記してください。

Go言語に関するチェックリスト

  • コードは gofmt でフォーマットされている
  • go vet を実行して潜在的な問題がないことを確認
  • ユニットテストが追加/更新されている
  • パフォーマンスに影響する変更はベンチマークを通して評価されている
  • 依存関係の更新は適切に管理されている
  • エラーハンドリングが適切に行われている
  • Goのコーディング規約に準拠している
  • バグが修正されていること

影響範囲とリスク

  • この変更が及ぼす影響と潜在的なリスクについて説明してください。

テスト戦略

  • どのようにしてこれらの変更が正しいことをテストしたか説明してください。

追加情報 (任意)

  • レビュワーに伝えたいその他の情報や、関連するIssueなどがあればこちらに記載してください。

@kynmh69 kynmh69 linked an issue Sep 29, 2024 that may be closed by this pull request
@kynmh69 kynmh69 self-assigned this Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

Qodana for Go

6 new problems were found

Inspection name Severity Problems
Unused exported function 🔶 Warning 3
Unhandled error 🔶 Warning 1
Duplicated code fragment ◽️ Notice 1
Type assertion on errors fails on wrapped errors ◽️ Notice 1

☁️ View the detailed Qodana report

Detected 75 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
github.com/DATA-DOG/go-sqlmock v1.5.0 BSD-3-Clause
github.com/bytedance/sonic/loader v0.1.1 Apache-2.0
github.com/bytedance/sonic v1.11.6 Apache-2.0
github.com/cloudwego/base64x v0.1.4 Apache-2.0
github.com/cloudwego/iasm v0.2.0 Apache-2.0
github.com/creack/pty v1.1.9 MIT
github.com/davecgh/go-spew v1.1.1 ISC
github.com/denisenkom/go-mssqldb v0.10.0 BSD-3-Clause
github.com/doug-martin/goqu/v9 v9.19.0 MIT
github.com/gabriel-vasile/mimetype v1.4.3 MIT
github.com/gin-contrib/sse v0.1.0 MIT
github.com/gin-gonic/gin v1.10.0 MIT
github.com/go-playground/assert/v2 v2.2.0 MIT
github.com/go-playground/locales v0.14.1 MIT
github.com/go-playground/universal-translator v0.18.1 MIT
github.com/go-playground/validator/v10 v10.20.0 MIT
github.com/go-sql-driver/mysql v1.6.0 MPL-2.0
github.com/goccy/go-json v0.10.2 MIT
github.com/golang-jwt/jwt v3.2.2+incompatible MIT
github.com/golang-sql/civil v0.0.0-20190719163853-cb61b32ac6fe Apache-2.0
github.com/golang/protobuf v1.5.0 BSD-3-Clause
github.com/google/go-cmp v0.5.9 BSD-3-Clause
github.com/google/gofuzz v1.0.0 Apache-2.0
github.com/google/uuid v1.6.0 BSD-3-Clause
github.com/jackc/pgpassfile v1.0.0 MIT
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 MIT
github.com/jackc/pgx/v5 v5.7.1 MIT
github.com/jackc/puddle/v2 v2.2.2 MIT
github.com/jinzhu/inflection v1.0.0 MIT
github.com/jinzhu/now v1.1.5 MIT
github.com/json-iterator/go v1.1.12 MIT
github.com/klauspost/cpuid/v2 v2.2.7 MIT
github.com/knz/go-libedit v1.10.1 Apache-2.0
github.com/kr/pretty v0.3.1 MIT
github.com/kr/text v0.2.0 MIT
github.com/labstack/echo/v4 v4.11.4 MIT
github.com/labstack/gommon v0.4.2 MIT
github.com/leodido/go-urn v1.4.0 MIT
github.com/lib/pq v1.10.1 MIT
github.com/mattn/go-colorable v0.1.13 MIT
github.com/mattn/go-isatty v0.0.20 MIT
github.com/mattn/go-sqlite3 v1.14.7 MIT
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd Apache-2.0
github.com/modern-go/reflect2 v1.0.2 Apache-2.0
github.com/pelletier/go-toml/v2 v2.2.2 MIT
github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e BSD-3-Clause
github.com/pmezard/go-difflib v1.0.0 BSD-3-Clause
github.com/rogpeppe/go-internal v1.13.1 BSD-3-Clause
github.com/stretchr/objx v0.5.2 MIT
github.com/stretchr/testify v1.9.0 MIT
github.com/twitchyliquid64/golang-asm v0.15.1 BSD-3-Clause
github.com/ugorji/go/codec v1.2.12 MIT
github.com/valyala/bytebufferpool v1.0.0 MIT
github.com/valyala/fasttemplate v1.2.2 MIT
go.uber.org/goleak v1.3.0 MIT
go.uber.org/multierr v1.10.0 MIT
go.uber.org/zap v1.27.0 MIT
golang.org/x/arch v0.8.0 BSD-3-Clause
golang.org/x/crypto v0.27.0 BSD-3-Clause
golang.org/x/mod v0.18.0 BSD-3-Clause
golang.org/x/net v0.25.0 BSD-3-Clause
golang.org/x/sync v0.8.0 BSD-3-Clause
golang.org/x/sys v0.25.0 BSD-3-Clause
golang.org/x/term v0.24.0 BSD-3-Clause
golang.org/x/text v0.18.0 BSD-3-Clause
golang.org/x/time v0.5.0 BSD-3-Clause
golang.org/x/tools v0.22.0 BSD-3-Clause
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 BSD-3-Clause
google.golang.org/protobuf v1.34.1 BSD-3-Clause
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c BSD-2-Clause
gopkg.in/yaml.v3 v3.0.1 Apache-2.0
MIT
gorm.io/driver/postgres v1.5.9 MIT
gorm.io/gorm v1.25.12 MIT
nullprogram.com/x/optparse v1.0.0 Unlicense
rsc.io/pdf v0.1.1 BSD-3-Clause
Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 64.81481% with 19 lines in your changes missing coverage. Please review.

Project coverage is 60.36%. Comparing base (bc3ae1c) to head (153e1c1).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/updater/controller/save_holidays.go 62.50% 8 Missing and 4 partials ⚠️
src/updater/main.go 0.00% 4 Missing ⚠️
src/api/handler/is_holiday.go 71.42% 1 Missing and 1 partial ⚠️
src/api/handler/get_holidays.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   61.63%   60.36%   -1.27%     
==========================================
  Files          11       11              
  Lines         232      217      -15     
==========================================
- Hits          143      131      -12     
  Misses         66       66              
+ Partials       23       20       -3     
Flag Coverage Δ
smart-tests 60.36% <64.81%> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kynmh69 kynmh69 marked this pull request as ready for review October 4, 2024 23:51
@kynmh69 kynmh69 merged commit d9b1271 into main Oct 4, 2024
17 checks passed
@kynmh69 kynmh69 deleted the 46-feature-mod-goqu-to-gorm branch October 4, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature mod goqu to gorm
1 participant