取り込み #44
Merged
取り込み #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable ECR deployment step in GitHub Actions workflow. Commented out the ECR deployment steps including AWS credentials setup, Docker Buildx setup, and Docker image build and push actions. This change pauses the deployment to ECR, allowing for adjustments or testing without triggering deployments.
IntelliJ IDEA project files should not be tracked in Git. This update helps keep the repository clean and prevents accidental commits of local IDE configurations.
Commented out the deploy steps in the `docker-publish-key-manager.yml` workflow. This change prevents the deployment to Amazon ECR, including steps for build setup, AWS credentials configuration, and Docker image building and pushing.
Commented out the deploy step in the GitHub Actions workflow file. This includes disabling steps related to Docker build, AWS credentials configuration, and ECR login. This update halts automatic deployment to ECR in the current setup.
fix: update Dockerfile for Go build and deployment - Use golang:1.23 for building the updater - Copy source files to /go/app/ - Set working directory to /go/app and download dependencies - Build the updater binary with CGO_ENABLED=0 - Use alpine:latest for the final image - Add zoneinfo.tar.gz to the root directory - Copy the built binary to /usr/local/bin/ - Set the default command to run the binary
40 ecsへのデプロイができない
Bumps the npm_and_yarn group with 1 update in the /src/key_management directory: [braces](https://github.com/micromatch/braces). Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]>
…anagement/npm_and_yarn-5134b82be1 Bump braces from 3.0.2 to 3.0.3 in /src/key_management in the npm_and_yarn group across 1 directory
Add qodana CI checks
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
プルリクエストのタイトル
概要
issueの番号
変更内容
Go言語に関するチェックリスト
gofmtでフォーマットされているgo vetを実行して潜在的な問題がないことを確認影響範囲とリスク
テスト戦略
追加情報 (任意)