Use prod image builder #9539

dekiel · 2023-12-18T00:51:35Z

Description

image-builder image which was used in prowjobs was build manually and maintained in neighbors dev registry.
Since image-builder is build with CI system and pushed to the prod registry it should be used in all prowjobs.

Changes proposed in this pull request:

Use image-builder image build in CI.

Updated the 'run_if_changed' patterns in the 'images.yaml' file for more precise reaction to changes. Furthermore, '--export-tags' option was removed for building image-builder as tags are not used in build process. A post-build job for image-builder was added. Now, every time changes are detected in the specified paths in 'main' branch, the image-builder image will be built automatically. This reduces manual effort and ensures that the latest code changes are incorporated in the image-builder.

…roject#9437)

kyma-project#9456) * tag telemetry-manager image with module version and remove release job * tag telemetry-manager image with module version in a separate job * change job name * add auto-generated empty line

…-project#9474) Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.152.0 to 0.153.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.152.0...v0.153.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps golang from 1.21.4-alpine3.17 to 1.21.5-alpine3.17. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) No eu.gcr.io/kyma-project/test-infra/ changes. No europe-docker.pkg.dev/kyma-project/prod/testimages/ changes. Multiple distinct europe-docker.pkg.dev/kyma-project/prod/test-infra/ changes: Commits | Dates | Images --- | --- | --- kyma-project/test-infra@e65a3f7...ba72d49 | 2023‑12‑04 → 2023‑12‑06 | prod/test-infra/ko/clusterscollector, prod/test-infra/ko/cors-proxy, prod/test-infra/ko/diskscollector, prod/test-infra/ko/dnscollector, prod/test-infra/ko/externalsecretschecker, prod/test-infra/ko/gardener-rotate, prod/test-infra/ko/gcscleaner, prod/test-infra/ko/github-webhook-gateway, prod/test-infra/ko/image-detector, prod/test-infra/ko/image-syncer, prod/test-infra/ko/image-url-helper, prod/test-infra/ko/ipcleaner, prod/test-infra/ko/markdown-index, prod/test-infra/ko/move-gcs-bucket, prod/test-infra/ko/needs-tws, prod/test-infra/ko/orphanremover, prod/test-infra/ko/pjtester, prod/test-infra/ko/scan-logs-for-secrets, prod/test-infra/ko/search-github-issue, prod/test-infra/ko/usersmapchecker, prod/test-infra/ko/vmscollector kyma-project/test-infra@57f98c4...ba72d49 | 2023‑12‑04 → 2023‑12‑06 | prod/test-infra/slackmessagesender

…yma-project#9480) Bumps golang from 1.21.4-alpine3.17 to 1.21.5-alpine3.17. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…project#9475) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.17.0 to 1.18.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps golang from 1.21.4-alpine3.17 to 1.21.5-alpine3.17. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) No eu.gcr.io/kyma-project/test-infra/ changes. europe-docker.pkg.dev/kyma-project/prod/testimages/ changes: kyma-project/test-infra@57f98c4...59f0cdf (2023‑12‑04 → 2023‑12‑06) europe-docker.pkg.dev/kyma-project/prod/test-infra/ changes: kyma-project/test-infra@ba72d49...37d4a17 (2023‑12‑06 → 2023‑12‑06)

) No eu.gcr.io/kyma-project/test-infra/ changes. No europe-docker.pkg.dev/kyma-project/prod/testimages/ changes. europe-docker.pkg.dev/kyma-project/prod/test-infra/ changes: kyma-project/test-infra@37d4a17...f9e8ceb (2023‑12‑06 → 2023‑12‑06)

* Use semantic versioning for eventing manager * Restore template

…oject#9486) * chore: Remove cli related e2e test that use kyma deploy * cleanup templates * cleanup templates * revert integration

* Ignore docker images based on regexp * Update cloud run config as well

kyma-project#9498) * allow post build job to run on release-* branches for eventing-manager * remove skip instruction * add formatting and add release branch instruction

Bumps alpine from 3.18.5 to 3.19.0. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…project#9501) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.18.0...v1.18.1) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…yma-project#9502) Bumps alpine from 3.18.5 to 3.19.0. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) No eu.gcr.io/kyma-project/test-infra/ changes. No europe-docker.pkg.dev/kyma-project/prod/testimages/ changes. Multiple distinct europe-docker.pkg.dev/kyma-project/prod/test-infra/ changes: Commits | Dates | Images --- | --- | --- kyma-project/test-infra@f9e8ceb...e0b1571 | 2023‑12‑06 → 2023‑12‑08 | prod/test-infra/ko/clusterscollector, prod/test-infra/ko/cors-proxy, prod/test-infra/ko/diskscollector, prod/test-infra/ko/dnscollector, prod/test-infra/ko/externalsecretschecker, prod/test-infra/ko/gardener-rotate, prod/test-infra/ko/gcscleaner, prod/test-infra/ko/github-webhook-gateway, prod/test-infra/ko/image-detector, prod/test-infra/ko/image-syncer, prod/test-infra/ko/image-url-helper, prod/test-infra/ko/ipcleaner, prod/test-infra/ko/markdown-index, prod/test-infra/ko/move-gcs-bucket, prod/test-infra/ko/needs-tws, prod/test-infra/ko/orphanremover, prod/test-infra/ko/pjtester, prod/test-infra/ko/scan-logs-for-secrets, prod/test-infra/ko/search-github-issue, prod/test-infra/ko/usersmapchecker, prod/test-infra/ko/vmscollector kyma-project/test-infra@37d4a17...e0b1571 | 2023‑12‑06 → 2023‑12‑08 | prod/test-infra/slackmessagesender

…enting-manager The neighbors image will no longer be maintained, so we will replace it where it is used. More infos about this changes an be found at this PR: kyma-project#9539

Sawthis

Please also update image URL in the https://github.com/kyma-project/test-infra/blob/main/prow/cluster/resources/gatekeeper-constraints/workloads/saKymaPushImagesSecretTrustedUsage.yaml#L19

dekiel · 2024-01-16T13:26:06Z

Please also update image URL in the https://github.com/kyma-project/test-infra/blob/main/prow/cluster/resources/gatekeeper-constraints/workloads/saKymaPushImagesSecretTrustedUsage.yaml#L19

It's present in line 24 and 29.

# Conflicts: # prow/jobs/kyma-project/control-plane/components/provisioner/provisioner-subscription-cleanup-job-build.yaml # prow/jobs/kyma-project/serverless/serverless-build.yaml # prow/jobs/kyma-project/serverless/serverless-release.yaml # prow/jobs/kyma-project/test-infra/buildpack.yaml # prow/jobs/kyma-project/test-infra/images.yaml # sec-scanners-config.yaml # templates/data/test-infra/buildpack-data.yaml

kyma-bot · 2024-01-17T10:31:23Z

@dekiel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-build-image-builder	`b139509`	link	true	`/test pull-build-image-builder`
pull-build-buildkit-image-builder	`b139509`	link	true	`/test pull-build-buildkit-image-builder`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kyma-bot · 2024-01-17T13:18:42Z

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

9973d73 gomod(deps): bump google.golang.org/api from 0.152.0 to 0.153.0 (gomod(deps): bump google.golang.org/api from 0.152.0 to 0.153.0 #9474)
bc2bed7 actions(deps): bump actions/setup-go from 4 to 5 (actions(deps): bump actions/setup-go from 4 to 5 #9476)
bc92b09 docker-rotate-sa(deps): bump golang (docker-rotate-sa(deps): bump golang from 1.21.4-alpine3.17 to 1.21.5-alpine3.17 in /cmd/cloud-run/rotate-service-account #9477)
66405ff move-gcs-bucket(deps): bump golang in /cmd/cloud-run/move-gcs-bucket (move-gcs-bucket(deps): bump golang from 1.21.4-alpine3.17 to 1.21.5-alpine3.17 in /cmd/cloud-run/move-gcs-bucket #9480)
89b8b0b gomod(deps): bump github.com/spf13/viper from 1.17.0 to 1.18.0 (gomod(deps): bump github.com/spf13/viper from 1.17.0 to 1.18.0 #9475)
94693f9 ginkgo(deps): bump golang in /prow/images/ginkgo (ginkgo(deps): bump golang from 1.21.4-alpine3.17 to 1.21.5-alpine3.17 in /prow/images/ginkgo #9478)
d2d58e9 docker-rotate-sa(deps): bump alpine (docker-rotate-sa(deps): bump alpine from 3.18.5 to 3.19.0 in /cmd/cloud-run/rotate-service-account #9500)
1154d0f gomod(deps): bump github.com/spf13/viper from 1.18.0 to 1.18.1 (gomod(deps): bump github.com/spf13/viper from 1.18.0 to 1.18.1 #9501)
114206b move-gcs-bucket(deps): bump alpine in /cmd/cloud-run/move-gcs-bucket (move-gcs-bucket(deps): bump alpine from 3.18.5 to 3.19.0 in /cmd/cloud-run/move-gcs-bucket #9502)
3779f97 slack-msg-sender(deps): bump python (slack-msg-sender(deps): bump python from 3.12.0-alpine3.18 to 3.12.1-alpine3.18 in /cmd/cloud-run/slack-message-sender #9513)
ff9c38b tf(deps): bump hashicorp/google in /configs/terraform/core (tf(deps): bump hashicorp/google from 5.8.0 to 5.9.0 in /configs/terraform/core #9512)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dekiel and others added 30 commits December 16, 2023 20:27

Allow admins to bypass branch protection in community-modules (kyma-p…

6ff0865

…roject#9437)

Remove unused script from Istio reconciler testing (kyma-project#9468)

c37fca1

Tag telemetry-manager image with module version and remove release job (

c12d34d

kyma-project#9456) * tag telemetry-manager image with module version and remove release job * tag telemetry-manager image with module version in a separate job * change job name * add auto-generated empty line

job_removed (kyma-project#9471)

47ab59d

Bumping sec-scanners-config.yaml (kyma-project#9458)

a27040b

Bump natsio images (kyma-project#9469)

acfab5a

Remove the eventing manager template. (kyma-project#9484)

7459628

Use semantic versioning for eventing manager (kyma-project#9473)

c5ff46d

* Use semantic versioning for eventing manager * Restore template

Adds a setting to ignore non-required tide contexts (kyma-project#9485)

8cc35f8

fix run_if_changed (kyma-project#9487)

a6fe7e8

chore: Remove cli related k3d pipelines that use kyma deploy (kyma-pr…

6e00005

…oject#9486) * chore: Remove cli related e2e test that use kyma deploy * cleanup templates * cleanup templates * revert integration

Ignore docker images based on regexp (kyma-project#9488)

d9f4429

* Ignore docker images based on regexp * Update cloud run config as well

Bumping sec-scanners-config.yaml (kyma-project#9483)

db483d5

add two missing required job (kyma-project#9489)

1dd9587

allow post build job to run on release-* branches for eventing-manager (

9b9d11a

kyma-project#9498) * allow post build job to run on release-* branches for eventing-manager * remove skip instruction * add formatting and add release branch instruction

Bumping sec-scanners-config.yaml (kyma-project#9504)

0a83216

kyma-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 4, 2024

dekiel added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jan 4, 2024

friedrichwilken mentioned this pull request Jan 5, 2024

Use new builder image #9610

Closed

Merge branch 'main' into use-prod-image-builder

7680ac0

kyma-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 8, 2024

Sawthis approved these changes Jan 8, 2024

View reviewed changes

kyma-bot assigned Sawthis Jan 8, 2024

kyma-bot added the lgtm Looks good to me! label Jan 8, 2024

Disper previously approved these changes Jan 8, 2024

View reviewed changes

kyma-bot assigned Disper Jan 8, 2024

friedrichwilken mentioned this pull request Jan 9, 2024

Bump eventing builder images #9625

Closed

Sawthis requested changes Jan 12, 2024

View reviewed changes

kyma-bot removed the lgtm Looks good to me! label Jan 12, 2024

dekiel added 4 commits January 16, 2024 23:05

Merge remote-tracking branch 'upstream/main' into use-prod-image-builder

a0cc62e

Use image builder from prod registry.

3528bae

rendertemplate

b0ac0dd

dekiel dismissed Disper’s stale review via b0ac0dd January 17, 2024 10:26

Allow buildkit image-builder to use privileged conatainers.

0806c94

dekiel removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 17, 2024

Add buildkit image-builder to opa constraints.

6a3a8a2

kyma-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 17, 2024

dekiel closed this Feb 8, 2024

dekiel deleted the use-prod-image-builder branch February 8, 2024 10:36

dekiel mentioned this pull request Feb 8, 2024

Use prod image-builder image in prowjobs #9826

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use prod image builder #9539

Use prod image builder #9539

dekiel commented Dec 18, 2023 •

edited

Loading

Sawthis left a comment

dekiel commented Jan 16, 2024

kyma-bot commented Jan 17, 2024 •

edited

Loading

kyma-bot commented Jan 17, 2024

Use prod image builder #9539

Use prod image builder #9539

Conversation

dekiel commented Dec 18, 2023 • edited Loading

Sawthis left a comment

Choose a reason for hiding this comment

dekiel commented Jan 16, 2024

kyma-bot commented Jan 17, 2024 • edited Loading

kyma-bot commented Jan 17, 2024

dekiel commented Dec 18, 2023 •

edited

Loading

kyma-bot commented Jan 17, 2024 •

edited

Loading