-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature of building images in ADO #8806
Conversation
Skipping CI for Draft Pull Request. |
# Conflicts: # go.mod
# Conflicts: # cmd/image-builder/main.go # go.mod
This comment has been minimized.
This comment has been minimized.
# Conflicts: # go.mod
…uitable for building image-builder.
Fix flag.
Co-authored-by: Kamil Kasperski <[email protected]>
@dekiel: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Changes proposed in this pull request:
Refactored image-builder code. Splitted or consolidated code in to few function for local and in ADO build backends.
Moved code for interaction with ado api in to separate package to make it testable and reusable.
Added tests.
Added few TODOs where improvements or missing parts were identified.
Aligned client with ADO pipeline parameters.
Added function for creating and validating pipeline parameters instance to make explicit which parameters exist in ado pipeline.
Added feature of signing only provided images. This is needed for building in ADO as a building images and signing are two separate steps in a pipeline. These two steps are executed by different tools.
Added feature of parsing image tags only. This is needed for building in ADO as a building and parsing tags are two separate steps executed by different tools.
Improved validation of options of image-builder. Validation is done earlier in the execution and validates more options.
Updated image-builder config with production pipeline data.
Related issue(s)
See #9237