Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature of building images in ADO #8806

Merged
merged 40 commits into from
Dec 4, 2023
Merged

Conversation

dekiel
Copy link
Contributor

@dekiel dekiel commented Aug 29, 2023

Description

Changes proposed in this pull request:

Refactored image-builder code. Splitted or consolidated code in to few function for local and in ADO build backends.
Moved code for interaction with ado api in to separate package to make it testable and reusable.
Added tests.
Added few TODOs where improvements or missing parts were identified.
Aligned client with ADO pipeline parameters.
Added function for creating and validating pipeline parameters instance to make explicit which parameters exist in ado pipeline.
Added feature of signing only provided images. This is needed for building in ADO as a building images and signing are two separate steps in a pipeline. These two steps are executed by different tools.
Added feature of parsing image tags only. This is needed for building in ADO as a building and parsing tags are two separate steps executed by different tools.
Improved validation of options of image-builder. Validation is done earlier in the execution and validates more options.
Updated image-builder config with production pipeline data.

Related issue(s)
See #9237

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-kind labels Aug 29, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added needs-area size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 29, 2023
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2023
@dekiel dekiel changed the title Add sign-only mode. Add feature of building images in ADO Sep 29, 2023
@dekiel dekiel added kind/feature Categorizes issue or PR as related to a new feature. area/tools Issues or PRs related to overall changes in tools labels Nov 15, 2023

This comment has been minimized.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 30, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 30, 2023
cmd/image-builder/main.go Outdated Show resolved Hide resolved
cmd/image-builder/main.go Outdated Show resolved Hide resolved
cmd/image-builder/main.go Outdated Show resolved Hide resolved
@dekiel dekiel requested a review from mm-mariani December 3, 2023 22:41
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 4, 2023
@kyma-bot kyma-bot merged commit 57f98c4 into kyma-project:main Dec 4, 2023
12 checks passed
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 4, 2023

@dekiel: Updated the following 3 configmaps:

  • kaniko-build-config configmap in namespace default at cluster trusted-workload using the following files:
    • key kaniko-build-config.yaml using file configs/kaniko-build-config.yaml
  • kaniko-build-config configmap in namespace default at cluster untrusted-workload using the following files:
    • key kaniko-build-config.yaml using file configs/kaniko-build-config.yaml
  • job-config configmap in namespace default at cluster default using the following files:
    • key images.yaml using file prow/jobs/kyma-project/test-infra/images.yaml

In response to this:

Description

Changes proposed in this pull request:

Refactored image-builder code. Splitted or consolidated code in to few function for local and in ADO build backends.
Moved code for interaction with ado api in to separate package to make it testable and reusable.
Added tests.
Added few TODOs where improvements or missing parts were identified.
Aligned client with ADO pipeline parameters.
Added function for creating and validating pipeline parameters instance to make explicit which parameters exist in ado pipeline.
Added feature of signing only provided images. This is needed for building in ADO as a building images and signing are two separate steps in a pipeline. These two steps are executed by different tools.
Added feature of parsing image tags only. This is needed for building in ADO as a building and parsing tags are two separate steps executed by different tools.
Improved validation of options of image-builder. Validation is done earlier in the execution and validates more options.
Updated image-builder config with production pipeline data.

Related issue(s)
See #9237

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dekiel dekiel deleted the sign-only branch December 4, 2023 17:22
@dekiel dekiel assigned dekiel and unassigned Sawthis and mm-mariani Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-or-update area/tools Issues or PRs related to overall changes in tools cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants