Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove module version file #247

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

ruanxin
Copy link
Contributor

@ruanxin ruanxin commented Sep 3, 2024

Description

Align template operator release with klm, remove the version validation based on a fixed version file.

Related issue(s)
kyma-project/lifecycle-manager#1811

@ruanxin ruanxin requested a review from a team as a code owner September 3, 2024 09:38
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2024
Comment on lines +28 to +29
- name: Validate the release tag
run: ./validate_release_tag.sh ${{ github.event.inputs.name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also just re-use the existing script from lifecycle-manager? We could checkout the lifecycle manager and invoke the script from there. Then we would not get unaligned again in the future.

Copy link
Contributor Author

@ruanxin ruanxin Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not a good practice to build dependencies for these two repos just because of reusing this script. IMO, different repos should have their pipeline code. If certain code is worth sharing, then designing it as a customized github action is the right direction. https://docs.github.com/en/actions/sharing-automations

But the functionality of this script is simple, the efforts to publish it as github action is not worth it. Keeping the script separate is also not bad, it allows us to design different validations for both repos if needed in the future.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 3, 2024
@kyma-bot kyma-bot merged commit f7a3c4e into kyma-project:main Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants