Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Version upgrades: go 1.22.1, kustomize: 5.3, controller tools: 0.14 #164

Merged
merged 4 commits into from
Mar 11, 2024
Merged

chore: Version upgrades: go 1.22.1, kustomize: 5.3, controller tools: 0.14 #164

merged 4 commits into from
Mar 11, 2024

Conversation

lindnerby
Copy link
Member

@lindnerby lindnerby commented Mar 7, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • golang upgrade for docker builder to 1.22.1
  • also results in needing to upgrade kustomize to 5.3.0
  • also results in needing to upgrade controller tools to 0.14
  • use golang 1.22.1 in E2E (from go.mod)
  • re-generate crds! results in different formatting in description fields

@lindnerby lindnerby requested a review from a team as a code owner March 7, 2024 08:30
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2024
@lindnerby lindnerby changed the title chore: Bump version chore: Version upgrades: go 1.22.1, kustomize: 5.3, controller tools: 0.14 Mar 8, 2024
@lindnerby lindnerby added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
@lindnerby lindnerby mentioned this pull request Mar 8, 2024
Merged
@nesmabadr
Copy link
Contributor

nesmabadr commented Mar 8, 2024 •
edited
Loading

Please upgrade the go version in the api package as well https://github.com/kyma-project/template-operator/blob/main/api/go.mod#L3

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 11, 2024
@lindnerby lindnerby enabled auto-merge (squash) March 11, 2024 09:25
@lindnerby lindnerby removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@kyma-bot kyma-bot merged commit 2c9db24 into kyma-project:main Mar 11, 2024
7 checks passed
auto-merge was automatically disabled March 11, 2024 09:29

Base branch was modified

@lindnerby lindnerby deleted the go-122 branch March 11, 2024 09:30
@jeremyharisch jeremyharisch assigned lindnerby and unassigned nesmabadr Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees

@lindnerby lindnerby

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindnerby @nesmabadr @kyma-bot