Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add ADR for module status metrics #995

Merged
merged 9 commits into from
Apr 30, 2024

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Apr 22, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Add ADR for module status metrics

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2024
@chrkl chrkl marked this pull request as ready for review April 26, 2024 07:32
@chrkl chrkl requested a review from a team as a code owner April 26, 2024 07:32
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
@chrkl chrkl force-pushed the kymastatsmetrics-proposal branch from 809850a to fe7ea15 Compare April 26, 2024 14:48
shorim
shorim previously approved these changes Apr 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 26, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 29, 2024
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
@chrkl chrkl force-pushed the kymastatsmetrics-proposal branch from c1fa8e0 to 319654a Compare April 30, 2024 12:16
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
- operator.kyma-project.io
```

The receiver needs the following properties:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put this section (line 69-73) before the example of line 57-67.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
docs/contributor/arch/011-kymastatsmetrics.md Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 30, 2024
@kyma-bot kyma-bot merged commit c793a03 into kyma-project:main Apr 30, 2024
6 checks passed
@chrkl chrkl deleted the kymastatsmetrics-proposal branch April 30, 2024 15:25
@a-thaler a-thaler added area/metrics MetricPipeline kind/decision Marks a decision document labels Apr 30, 2024
@a-thaler a-thaler added this to the 1.15.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/decision Marks a decision document lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants