Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add ADR for LogPipeline health status #934

Merged
merged 5 commits into from
Mar 28, 2024
Merged

docs: Add ADR for LogPipeline health status #934

merged 5 commits into from
Mar 28, 2024

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Mar 28, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Describe condition reasons for LogPipeline flow health

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@chrkl chrkl requested a review from a team as a code owner March 28, 2024 13:03
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2024
@chrkl chrkl force-pushed the logging-health-adr branch from 8f302e6 to e18589f Compare March 28, 2024 13:13
hisarbalik
hisarbalik previously approved these changes Mar 28, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 28, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 28, 2024
@chrkl
Copy link
Contributor Author

chrkl commented Mar 28, 2024

/test pull-telemetry-manager-build

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 28, 2024
@kyma-bot kyma-bot merged commit 0e7c063 into kyma-project:main Mar 28, 2024
7 checks passed
@chrkl chrkl deleted the logging-health-adr branch March 28, 2024 13:50
@chrkl chrkl mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@hisarbalik hisarbalik hisarbalik left review comments

Assignees

@hisarbalik hisarbalik

@NHingerl NHingerl

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrkl @hisarbalik @NHingerl @kyma-bot