Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Change the name of the WORKDIR in Dockerfile #875

Merged
merged 2 commits into from
Mar 12, 2024
Merged

chore: Change the name of the WORKDIR in Dockerfile #875

merged 2 commits into from
Mar 12, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Mar 11, 2024

Description

Changes proposed in this pull request (what was done and why):

  • The /workspace directory is used by kaniko executor as well and it overlaps during build

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@shorim shorim added kind/chore Categorizes issue or PR as related to a chore. area/manager Manager or module changes labels Mar 11, 2024
@shorim shorim added this to the 1.11.0 milestone Mar 11, 2024
@shorim shorim requested a review from a team as a code owner March 11, 2024 15:30
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 12, 2024
a-thaler
a-thaler requested changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@a-thaler a-thaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still does not work

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 12, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 12, 2024
@kyma-bot kyma-bot merged commit fdac4fd into kyma-project:main Mar 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-thaler a-thaler a-thaler approved these changes

Assignees

@a-thaler a-thaler

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shorim @a-thaler @kyma-bot