Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce v1beta1 API for experimental channel #869

Merged
merged 19 commits into from
Mar 14, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Mar 8, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Create a v1beta1 version for LogPipeline, TracePipeline and MetricPipeline. Currently, they are just clones of the CRDs in the v1alpha1 version.
  • The kubebuilder marker +kubebuilder:storageversion is explicitly set for the types in the v1beta1 package. Therefore, when the CRDs are auto-generated for the development variant, the v1beta1 version is set as the stored version
  • Adjust the existing manifests target to auot-generate only the CRDs for the v1alpha1 version
  • Create a new target called manifests-dev which auto-generates the CRDs for both v1alpha1 and v1beta1 versions for the development release
  • Use manifests-dev target as a dependency in deploy-dev target
  • Rename otlp in the names of fields, types and functions to OTLP

Changes refer to particular issues, PRs or documents:
#848

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@shorim shorim added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/manager Manager or module changes labels Mar 8, 2024
@shorim shorim added this to the 1.11.0 milestone Mar 8, 2024
@shorim shorim requested a review from a team as a code owner March 8, 2024 21:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 8, 2024
@shorim shorim added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@skhalash skhalash removed this from the 1.11.0 milestone Mar 12, 2024
@shorim shorim added this to the 1.12.0 milestone Mar 12, 2024
@shorim shorim removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 14, 2024
@kyma-bot kyma-bot merged commit 4fbb215 into kyma-project:main Mar 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants