generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce v1beta1 API for experimental channel #869
Merged
kyma-bot
merged 19 commits into
kyma-project:main
from
shorim:beta_api_as_experimental_feature
Mar 14, 2024
Merged
feat: Introduce v1beta1 API for experimental channel #869
kyma-bot
merged 19 commits into
kyma-project:main
from
shorim:beta_api_as_experimental_feature
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorim
added
kind/feature
Categorizes issue or PR as related to a new feature.
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
area/manager
Manager or module changes
labels
Mar 8, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
labels
Mar 8, 2024
shorim
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 11, 2024
skhalash
requested changes
Mar 12, 2024
shorim
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 14, 2024
skhalash
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/manager
Manager or module changes
cla: yes
Indicates the PR's author has signed the CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Looks good to me!
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
v1beta1
version for LogPipeline, TracePipeline and MetricPipeline. Currently, they are just clones of the CRDs in thev1alpha1
version.+kubebuilder:storageversion
is explicitly set for the types in thev1beta1
package. Therefore, when the CRDs are auto-generated for the development variant, thev1beta1
version is set as the stored versionmanifests
target to auot-generate only the CRDs for thev1alpha1
versionmanifests-dev
which auto-generates the CRDs for bothv1alpha1
andv1beta1
versions for the development releasemanifests-dev
target as a dependency indeploy-dev
targetotlp
in the names of fields, types and functions toOTLP
Changes refer to particular issues, PRs or documents:
#848
Traceability
area
andkind
label.Related Issues
section.