Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor status handling #852

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Mar 5, 2024

Description

Changes proposed in this pull request (what was done and why):

Tackling the suggestions from the comments in #833

  • Rename CommonMessageFor function to MessageFor in order to have a better reflection of its new logic
  • Remove removePendingAndRunningConditions function from both traceComponentsChecker and logComponentsChecker. The deprecated conditions (Running and Pending) are already ignored in the firstUnhealthyPipelineReason function
  • Remove extra newTag field in manager kustomization

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@shorim shorim added kind/chore Categorizes issue or PR as related to a chore. area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline labels Mar 5, 2024
@shorim shorim added this to the 1.11.0 milestone Mar 5, 2024
@shorim shorim requested a review from a team as a code owner March 5, 2024 13:25
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 5, 2024
@kyma-bot kyma-bot merged commit a51e99c into kyma-project:main Mar 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants