Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Validate Istio metric attributes #662

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Dec 21, 2023

Description

Changes proposed in this pull request (what was done and why):

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@chrkl chrkl added kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. area/metrics MetricPipeline labels Dec 21, 2023
@chrkl chrkl requested a review from a team as a code owner December 21, 2023 12:21
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 21, 2023
@kyma-bot kyma-bot merged commit 864ce36 into kyma-project:main Dec 21, 2023
17 checks passed
@chrkl chrkl deleted the validate-istio-attributes branch December 21, 2023 14:12
@a-thaler a-thaler added this to the 1.7.0 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants