Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing metric-gateway-priority-class argument #659

Merged

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Dec 20, 2023

Description

Changes proposed in this pull request (what was done and why):

  • Add the missing metric-gateway-priority-class argument when running the manager container. In the PR for including the metrics feature in releases, we removed the Kustomize patch for the manager deployment, as it was not needed anymore, since the metrics feature will be enabled by default. However, it was forgotten to copy over the argument for the metric-gateway-priority-class to the manager deployment.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@shorim shorim added kind/bug Categorizes issue or PR as related to a bug. area/metrics MetricPipeline labels Dec 20, 2023
@shorim shorim requested a review from a team as a code owner December 20, 2023 13:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 20, 2023
@kyma-bot kyma-bot merged commit ae64ce2 into kyma-project:main Dec 20, 2023
22 checks passed
@shorim shorim added this to the 1.6.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants