Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider the existence of Istio when applying and deleting resources for Log Gateway #1668

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Dec 10, 2024

Description

Changes proposed in this pull request (what was done and why):

  • When initializing otelcollector.GatewayApplyOptions for Log Gateway:
    • Pass the missing IstioEnabled and IstioExcludePorts fields
    • Pass the missing AllowedPorts field (for NetworkPolicy)
  • Add istio sidecar injection for Log Gateway
  • Adjust gatewayApplierDeleter.DeleteResources in Log Gateway to use istioStatusChecker

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@shorim shorim added kind/bug Categorizes issue or PR as related to a bug. area/logs LogPipeline labels Dec 10, 2024
@shorim shorim added this to the 1.30.0 milestone Dec 10, 2024
@shorim shorim requested a review from a team as a code owner December 10, 2024 23:22
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2024
@hisarbalik hisarbalik self-assigned this Dec 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 12, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 12, 2024
@hisarbalik hisarbalik self-requested a review December 12, 2024 08:39
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 12, 2024
@hisarbalik hisarbalik merged commit f32da99 into kyma-project:main Dec 12, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants