Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor OTel resources #1659

Merged
merged 28 commits into from
Dec 9, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Dec 5, 2024

Description

Changes proposed in this pull request (what was done and why):

  • The esources/otelcollector package previously defined a "generic" gateway/agent applier-deleter, which required external configuration. However, as gateways for different signal types (e.g., metrics and traces) diverged, the number of configuration parameters increased, leading to complexity.

This PR encapsulates the logic for handling different concrete gateways and agents, simplifying the usage of the package. Additionally, it lays the groundwork for easier integration of log agent support in the future.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline labels Dec 5, 2024
@skhalash skhalash added this to the 1.30.0 milestone Dec 5, 2024
@skhalash skhalash requested a review from a team as a code owner December 5, 2024 09:51
@skhalash skhalash changed the title Refactor OTel resources chore: Refactor OTel resources Dec 5, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 5, 2024
@skhalash skhalash added the kind/chore Categorizes issue or PR as related to a chore. label Dec 5, 2024
.testcoverage.yml Outdated Show resolved Hide resolved
@skhalash skhalash enabled auto-merge (squash) December 6, 2024 14:28
internal/reconciler/logpipeline/otel/reconciler.go Outdated Show resolved Hide resolved
.testcoverage.yml Show resolved Hide resolved
controllers/telemetry/logpipeline_controller.go Outdated Show resolved Hide resolved
internal/utils/test/marshal.go Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 9, 2024
@skhalash skhalash merged commit fbcb5b1 into kyma-project:main Dec 9, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants