Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add merge_group trigger for workflows #1658

Merged
merged 6 commits into from
Dec 13, 2024
Merged

chore: Add merge_group trigger for workflows #1658

merged 6 commits into from
Dec 13, 2024

Conversation

jeffreylimnardy
Copy link
Contributor

@jeffreylimnardy jeffreylimnardy commented Dec 5, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Add merge_group trigger for pr-integration, pr-lifecycle, pr-code-checks, build-image, and pr-all-checks-passed workflows in all branch targets
  • Add merge_group trigger for branch-integration in release branch target
  • Handle merge_group events in build-image workflow to use merge_group SHA as tag
  • Handle waiting for build-image in merge_group events in pr-lifecycle, pr-integration and branch-integration workflows

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@jeffreylimnardy jeffreylimnardy added area/ci Test automation kind/chore Categorizes issue or PR as related to a chore. labels Dec 5, 2024
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024
@jeffreylimnardy jeffreylimnardy marked this pull request as ready for review December 5, 2024 11:38
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner December 5, 2024 11:38
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
@jeffreylimnardy jeffreylimnardy added this to the 1.30.0 milestone Dec 5, 2024
@k15r k15r self-assigned this Dec 13, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2024
@k15r k15r merged commit 4baa324 into kyma-project:main Dec 13, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r approved these changes

Assignees

@k15r k15r

@skhalash skhalash

Labels
area/ci Test automation cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffreylimnardy @k15r @skhalash @kyma-bot