Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Simplify admission webhook setup #1633

Merged
merged 9 commits into from
Nov 26, 2024
Merged

chore: Simplify admission webhook setup #1633

merged 9 commits into from
Nov 26, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Nov 25, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Simplify method naming - no need to mentioned the resource name in the SetupXxx func
  • Move validating webhook setups into the corresponding SetupWithManager

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added kind/chore Categorizes issue or PR as related to a chore. area/manager Manager or module changes labels Nov 25, 2024
@skhalash skhalash added this to the 1.29.0 milestone Nov 25, 2024
@skhalash skhalash requested a review from a team as a code owner November 25, 2024 09:44
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2024
@skhalash skhalash enabled auto-merge (squash) November 25, 2024 15:40
shorim
shorim reviewed Nov 26, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
@skhalash @shorim
Update main.go
7798847 
Co-authored-by: Mostafa Shorim <[email protected]>
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2024
@skhalash skhalash requested a review from shorim November 26, 2024 11:54
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 26, 2024
@skhalash skhalash merged commit 5032815 into kyma-project:main Nov 26, 2024
42 checks passed
@skhalash skhalash deleted the simplify-webhook-setup branch November 27, 2024 14:14
a-thaler added a commit that referenced this pull request Nov 28, 2024
@a-thaler
Merge branch 'bump-otel-image-version-0.114.0' of https://github.com/…
64b898b 
…hisarbalik/telemetry-manager into bump-otel-image-version-0.114.0

* 'bump-otel-image-version-0.114.0' of https://github.com/hisarbalik/telemetry-manager:
  chore: bump github.com/k3d-io/k3d/v5 from 5.7.4 to 5.7.5 in /internal/tools (#1640)
  chore: Make all-checks-passed run on re-requesting jobs (#1639)
  chore: Simplify admission webhook setup (#1633)
  chore: bump the istio group with 2 updates (#1635)
  chore: bump github.com/golangci/golangci-lint from 1.62.0 to 1.62.2 in /internal/tools (#1638)
  chore: bump github.com/onsi/gomega from 1.35.1 to 1.36.0 (#1637)
  chore: bump github.com/stretchr/testify from 1.9.0 to 1.10.0 (#1636)
  docs: Fix dead Jaeger link (#1634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorim shorim shorim approved these changes

Assignees

@shorim shorim

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skhalash @shorim @kyma-bot