Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert kustomization.yaml and provision-k3d.sh #1327

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

TeodorSAP
Copy link
Member

Description

Changes proposed in this pull request (what was done and why):

  • Revert mistakenly merged changes to kustomization.yaml and provision-k3d.sh

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@TeodorSAP TeodorSAP requested a review from a team as a code owner August 7, 2024 12:18
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 7, 2024
@TeodorSAP TeodorSAP added kind/chore Categorizes issue or PR as related to a chore. and removed lgtm Looks good to me! labels Aug 7, 2024
@k15r
Copy link
Contributor

k15r commented Aug 7, 2024

sorry :)

@TeodorSAP TeodorSAP added the area/tests Writing/adding/Refactoring tests or checks label Aug 7, 2024
@TeodorSAP TeodorSAP added this to the 1.22.0 milestone Aug 7, 2024
@skhalash
Copy link
Collaborator

skhalash commented Aug 7, 2024

Can you add a check to make sure it never happens again?

@TeodorSAP
Copy link
Member Author

TeodorSAP commented Aug 7, 2024

sorry :)

My fault, I should've been more careful during review :')

@TeodorSAP
Copy link
Member Author

TeodorSAP commented Aug 7, 2024

Can you add a check to make sure it never happens again?

For the kustomization file, you mean?

@skhalash
Copy link
Collaborator

skhalash commented Aug 7, 2024

Yeah, either a pre-commit hook or a GHA workflow step. I also often unintentionally commit it. @k15r What do you think?

@TeodorSAP
Copy link
Member Author

Yeah, either a pre-commit hook or a GHA workflow step. I also often unintentionally commit it. @k15r What do you think?

But what if we want to modify it in the future? Should the check also include some kind of "backdoor"?

@skhalash
Copy link
Collaborator

skhalash commented Aug 7, 2024

Then we can disable the check, look at the git history, we don't change it often

@TeodorSAP TeodorSAP added the lgtm Looks good to me! label Aug 7, 2024
@kyma-bot kyma-bot merged commit 4c101f4 into kyma-project:main Aug 7, 2024
46 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants