Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove legacy Running and Pending conditions #1214

Merged
merged 8 commits into from
Jun 27, 2024
Merged

feat: Remove legacy Running and Pending conditions #1214

merged 8 commits into from
Jun 27, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Jun 25, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Remove legacy Running and Pending conditions
  • Adapt the tests
  • Simplify the Busola extensions
  • Decrease coverage threshold

Note

One-time status cleanup in the LogPipeline, LogParser, and TracePipeline reconcilers is left for one more release to remove the deprecated conditions from the existing pipelines

Traceability

  • The PR is linked to a GitHub issue.
  • The PR has a milestone set.
  • The PR has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 25, 2024
@skhalash skhalash added this to the 1.19.0 milestone Jun 25, 2024
@skhalash skhalash added area/traces TracePipeline area/logs LogPipeline kind/feature Categorizes issue or PR as related to a new feature. labels Jun 25, 2024
@skhalash skhalash marked this pull request as ready for review June 25, 2024 13:23
@skhalash skhalash requested review from a team as code owners June 25, 2024 13:23
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@skhalash
Copy link
Collaborator Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
@skhalash skhalash added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 25, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@skhalash
Copy link
Collaborator Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
NHingerl
NHingerl previously approved these changes Jun 26, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 26, 2024
k15r
k15r reviewed Jun 27, 2024
View reviewed changes
internal/conditions/conditions.go Outdated
@@ -2,22 +2,12 @@ package conditions

const (
TypeAgentHealthy = "AgentHealthy"
TypeGatewayHealthy = "GatewayHealthy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lets keep alpha-numeric order

k15r
k15r previously approved these changes Jun 27, 2024
View reviewed changes
@skhalash skhalash dismissed stale reviews from k15r and NHingerl via c662542 June 27, 2024 07:43
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 27, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 27, 2024
@skhalash skhalash requested a review from NHingerl June 27, 2024 08:02
@kyma-bot kyma-bot merged commit 5fc374c into kyma-project:main Jun 27, 2024
29 of 30 checks passed
@skhalash skhalash deleted the remove-legacy-status-conditions branch June 27, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@k15r k15r k15r approved these changes

@NHingerl NHingerl Awaiting requested review from NHingerl

Assignees

@k15r k15r

@grego952 grego952

@NHingerl NHingerl

Labels
area/logs LogPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@skhalash @kyma-bot @k15r @grego952 @NHingerl