Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup Fluent Bit config generation #1204

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Jun 24, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Remove dead code for conditionally adding @INCLUDE statement for pipeline specific Fluent Bit sections

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The PR has a milestone set.
  • The PR has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@chrkl chrkl added kind/chore Categorizes issue or PR as related to a chore. area/logs LogPipeline labels Jun 24, 2024
@chrkl chrkl requested a review from a team as a code owner June 24, 2024 09:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2024
@a-thaler a-thaler added this to the 1.19.0 milestone Jun 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 24, 2024
@kyma-bot kyma-bot merged commit 31fae83 into kyma-project:main Jun 24, 2024
30 checks passed
@chrkl chrkl deleted the cleanup-fluent-bit-include branch June 24, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants