Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix rendering Gardener shoot spec #1104

Merged
merged 1 commit into from
May 22, 2024
Merged

chore: Fix rendering Gardener shoot spec #1104

merged 1 commit into from
May 22, 2024

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented May 22, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Fix rendering Gardener shoot spec in Makefile

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@chrkl chrkl added area/ci Test automation kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels May 22, 2024
@chrkl chrkl requested a review from a team as a code owner May 22, 2024 06:58
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 22, 2024
@kyma-bot kyma-bot merged commit b10bc67 into kyma-project:main May 22, 2024
27 checks passed
@chrkl chrkl deleted the fix-gardener-shoot-redering branch May 22, 2024 07:12
@a-thaler a-thaler modified the milestones: 1.17.0, 1.16.0 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/ci Test automation cla: yes Indicates the PR's author has signed the CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chrkl @skhalash @a-thaler @kyma-bot