Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix linting issues with 1.58.2 #1096

Merged
merged 1 commit into from
May 21, 2024
Merged

chore: Fix linting issues with 1.58.2 #1096

merged 1 commit into from
May 21, 2024

Conversation

k15r
Copy link
Contributor

@k15r k15r commented May 21, 2024

Description

Changes proposed in this pull request (what was done and why):

  • adjust to latest changes in golangci lint 1.58.2

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@k15r k15r requested a review from a team as a code owner May 21, 2024 09:48
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2024
@k15r k15r changed the title fix: linting issues with 1.58.2 fix: Linting issues with 1.58.2 May 21, 2024
@skhalash skhalash changed the title fix: Linting issues with 1.58.2 chore: Fix linting issues with 1.58.2 May 21, 2024
@skhalash skhalash added kind/chore Categorizes issue or PR as related to a chore. area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline area/manager Manager or module changes labels May 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 21, 2024
@skhalash skhalash added this to the 1.17.0 milestone May 21, 2024
@skhalash
Copy link
Collaborator

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@skhalash skhalash modified the milestones: 1.17.0, 1.16.0 May 21, 2024
@skhalash
Copy link
Collaborator

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@kyma-bot kyma-bot merged commit 1202621 into kyma-project:main May 21, 2024
28 of 29 checks passed
@chrkl chrkl mentioned this pull request May 21, 2024
Merged
8 tasks
@k15r k15r deleted the fix_linting branch May 21, 2024 11:20
chrkl pushed a commit to chrkl/telemetry-manager that referenced this pull request May 23, 2024
@k15r @chrkl
chore: Fix linting issues with 1.58.2 (kyma-project#1096)
7e436d8
@chrkl chrkl mentioned this pull request May 23, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/logs LogPipeline area/manager Manager or module changes area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@k15r @skhalash @kyma-bot