Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adapt .golangci.yaml for v1.58.0 #1040

Merged
merged 1 commit into from
May 6, 2024
Merged

chore: Adapt .golangci.yaml for v1.58.0 #1040

merged 1 commit into from
May 6, 2024

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented May 6, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Adapted linter config to deprecated and renamed linters in golangci-lint v1.58.0

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@chrkl chrkl requested a review from a team as a code owner May 6, 2024 13:38
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2024
@chrkl chrkl added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. area/ci Test automation and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2024
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 6, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 6, 2024
@a-thaler a-thaler added this to the 1.15.0 milestone May 6, 2024
@kyma-bot kyma-bot merged commit 1a79bee into kyma-project:main May 6, 2024
25 checks passed
@chrkl chrkl deleted the fix-linting branch May 6, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-thaler a-thaler a-thaler approved these changes

Assignees

@a-thaler a-thaler

Labels
area/ci Test automation cla: yes Indicates the PR's author has signed the CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chrkl @a-thaler @kyma-bot