Skip to content

Commit

Permalink
chore: Fix env variable injection for gardener integration test (#775)
Browse files Browse the repository at this point in the history
  • Loading branch information
a-thaler authored Feb 6, 2024
1 parent fdb4008 commit 0ee0c73
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/branch-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:
jobs:
gardener-integration-test:
strategy:
fail-fast: false # if one version is not working, continue tests on other versions
matrix:
k8s_version: [1.27, 1.28]
runs-on: ubuntu-latest
Expand All @@ -36,7 +37,6 @@ jobs:
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
GITHUB_OWNER: "${{ github.repository_owner }}"
GITHUB_REPO: "telemetry-manager"
GARDENER_K8S_VERSION: ${{ matrix.k8s_version }}

# save gardener kubeconfig to a temp file in order to pass it to the command
- name: Save serviceaccount to file
Expand All @@ -52,6 +52,7 @@ jobs:
GARDENER_SECRET_NAME: ${{ secrets.GARDENER_SECRET_NAME }}
GARDENER_PROJECT: ${{ secrets.GARDENER_PROJECT }}
GARDENER_SA_PATH: /tmp/gardener-sa.yaml
GARDENER_K8S_VERSION: ${{ matrix.k8s_version }}

- name: Send slack message on failure
uses: slackapi/slack-github-action@e28cf165c92ffef168d23c5c9000cffc8a25e117
Expand Down
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,7 @@ gardener-integration-test: ## Provision gardener cluster and run integration tes

.PHONY: provision-gardener
provision-gardener: kyma ## Provision gardener cluster with latest k8s version
${KYMA} provision gardener gcp -c ${GARDENER_SA_PATH} -n ${GARDENER_CLUSTER_NAME} -p ${GARDENER_PROJECT} -s ${GARDENER_SECRET_NAME} -k ${GARDENER_K8S_VERSION_FULL}\
--hibernation-start="00 ${HIBERNATION_HOUR} * * ?"
${KYMA} provision gardener gcp -c ${GARDENER_SA_PATH} -n ${GARDENER_CLUSTER_NAME} -p ${GARDENER_PROJECT} -s ${GARDENER_SECRET_NAME} -k ${GARDENER_K8S_VERSION_FULL} --hibernation-start="00 ${HIBERNATION_HOUR} * * ?"

.PHONY: deprovision-gardener
deprovision-gardener: kyma ## Deprovision gardener cluster
Expand Down

0 comments on commit 0ee0c73

Please sign in to comment.