Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Skip module updates requiring maintenance windows when not active #2206

Merged

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Jan 23, 2025

Description

Changes proposed in this pull request:

  • Implements a decorator implementing the maintenance window logic
  • once it looked up the module template via it's decorated instance, it:
    • checks if a maintenance window is required
    • if so, checks if it is active
  • if it is not active or an error happens, it sets an error and the template to nil
    • as a consequence, the manifest will not be updated and we continue to reconcile its current version
    • additionally, we display a message in the kyma module status
    • this is the same behavior as we have already for the version downgrade

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner January 23, 2025 15:32
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 23, 2025
@c-pius c-pius added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jan 23, 2025
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2025
@c-pius c-pius changed the title feat: Skip module updates requiring maintenance windows when no such … feat: Skip module updates requiring maintenance windows when not active Jan 23, 2025
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 23, 2025
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
lindnerby
lindnerby previously approved these changes Jan 24, 2025
Copy link
Member

@lindnerby lindnerby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 24, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 24, 2025
@c-pius c-pius removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2025
cmd/main.go Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 27, 2025
@lindnerby lindnerby merged commit b426a0c into kyma-project:main Jan 27, 2025
71 checks passed
@c-pius c-pius deleted the feat/skip-update-outside-maintenance branch January 27, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance Windows] Skip module upgrades during maintenance window
3 participants