Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce managed flag to KymaCR .spec.modules #1652

Merged
merged 2 commits into from
Jul 2, 2024
Merged

feat: Introduce managed flag to KymaCR .spec.modules #1652

merged 2 commits into from
Jul 2, 2024

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Jul 2, 2024

Description

Changes proposed in this pull request:

  • adds the .managed flag to KymaCR .spec.modules

Related issue(s)

@c-pius c-pius requested review from a team as code owners July 2, 2024 07:46
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2024
@c-pius c-pius added the confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of label Jul 2, 2024
lindnerby
lindnerby previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@lindnerby lindnerby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 2, 2024
@c-pius c-pius force-pushed the feat/kymacr-spec-modules-managed branch from 9417c7b to 80df801 Compare July 2, 2024 09:41
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 2, 2024
mmitoraj
mmitoraj reviewed Jul 2, 2024
View reviewed changes
docs/technical-reference/api/kyma-cr.md Outdated Show resolved Hide resolved
docs/technical-reference/api/kyma-cr.md Outdated Show resolved Hide resolved
docs/technical-reference/api/kyma-cr.md Outdated Show resolved Hide resolved
docs/technical-reference/api/kyma-cr.md Outdated Show resolved Hide resolved
docs/technical-reference/api/kyma-cr.md Outdated Show resolved Hide resolved
docs/technical-reference/api/kyma-cr.md Outdated Show resolved Hide resolved
@c-pius @mmitoraj
Doc suggestions
bd1347c 
Co-authored-by: Małgorzata Świeca <[email protected]>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 2, 2024
@kyma-bot kyma-bot merged commit b71285f into kyma-project:main Jul 2, 2024
42 checks passed
@c-pius c-pius deleted the feat/kymacr-spec-modules-managed branch July 2, 2024 11:19
c-pius added a commit to c-pius/lifecycle-manager that referenced this pull request Jul 3, 2024
@c-pius
Revert "feat: Introduce managed flag to KymaCR .spec.modules (kym…
e637288 
…a-project#1652)"

This reverts commit b71285f.
c-pius added a commit to c-pius/lifecycle-manager that referenced this pull request Jul 3, 2024
@c-pius
Revert "feat: Introduce managed flag to KymaCR .spec.modules (kym…
fb1150d 
…a-project#1652)"

This reverts commit b71285f.
kyma-bot pushed a commit that referenced this pull request Jul 3, 2024
@c-pius
chore: Revert "feat: Introduce managed flag to KymaCR `.spec.module…
4575398 
…s` (#1652)" (#1658)

Revert "feat: Introduce `managed` flag to KymaCR `.spec.modules` (#1652)"

This reverts commit b71285f.
@c-pius c-pius mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindnerby lindnerby lindnerby approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

Assignees

@mmitoraj mmitoraj

@lindnerby lindnerby

Labels
cla: yes Indicates the PR's author has signed the CLA. confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Deletion Modes] Introduce a managed field for each module in the Kyma CR Modules List
4 participants
@c-pius @mmitoraj @lindnerby @kyma-bot