-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove config layer #543
Comments
This issue or PR has been automatically marked as stale due to the lack of recent activity. This bot triages issues and PRs according to the following rules:
You can:
If you think that I work incorrectly, kindly raise an issue with the problem. /lifecycle stale |
The CLI part is already done with the new way of building the Modules (based on the config file and not the kubebuilder repo). |
…config-layer' into feature/kyma-project#543-remove-config-layer # Conflicts: # controllers/moduletemplate_test.go
…config-layer' into feature/kyma-project#543-remove-config-layer
…config-layer' into feature/kyma-project#543-remove-config-layer # Conflicts: # controllers/moduletemplate_test.go
One PR is still left |
…ure/kyma-project#714-watcher-cr-tests
Since now we only support raw manifest rendering, the config layer which was previously provided as helm chart, kustomize overwrite becomes useless. We should remove any config.yaml related code in lifecycle manager.
AC:
config.yaml
, and generated module template should not contains config layer.Be aware, eventually, manifest spec should not contain this config field, but this might introduce breaking changes, should plan it in next API version. In this issue, don't remove this Config field.
The text was updated successfully, but these errors were encountered: