Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deletion Modes] Implement Logic to Extract and Insert Associated Resources into Manifest CR associatedResources #1651

Closed
5 tasks done
jeremyharisch opened this issue Jul 2, 2024 · 0 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jeremyharisch
Copy link
Contributor

jeremyharisch commented Jul 2, 2024

Description

With the issue described in lifecycle-manager #1582, a new field called associatedResources is added to the Manifest Custom Resource. This change requires implementing logic to extract the list of managed resources from the ModuleTemplate and insert it into the manifest.spec. associatedResources .

The list of managed resources is an additional layer in the OCM specification. An example of this can be found in the implementation described in template-operator #200.

After implementing this logic, the Manifest CR should look like this:

[...]
spec:
  install:
    name: raw-manifest
    source:
      [...]
  remote: true
  resource:
    apiVersion: operator.kyma-project.io/v1alpha1
    kind: Sample
    metadata:
      name: sample-yaml
      namespace: kyma-system
    spec:
      resourceFilePath: ./module-data/yaml
  associatedResources: 
     - serverless.kyma-project.io/v1alpha2/functions
     - operator.kyma-project.io/v1alpha1/serverlesses
  version: 1.1.1

Reasons

  • Provide logic to extract managed resources from ModuleTemplate OCM Layer
  • Fill in manifest.spec. associatedResources list

Acceptance Criteria

  • Kyma Reconciliation Loop:
    • Extract managed resources from OCM layer (ModuleTemplate)
    • While creating Manifest CRs insert extracted managed resources into the manifest.spec. associatedResources
  • Cover newly introduced functions in Unit-Tests
  • Cover new functionality of Kyma reconciliation loop in integration test
@jeremyharisch jeremyharisch added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 2, 2024
@jeremyharisch jeremyharisch changed the title [Deletion Modes] Introduce [Deletion Modes] Implement Logic to Extract and Insert Managed Resources into Manifest CR Jul 2, 2024
@nesmabadr nesmabadr self-assigned this Jul 3, 2024
@nesmabadr nesmabadr removed their assignment Jul 11, 2024
@jeremyharisch jeremyharisch changed the title [Deletion Modes] Implement Logic to Extract and Insert Managed Resources into Manifest CR [Deletion Modes] Implement Logic to Extract and Insert Managed Resources into Manifest CR associatedResources Jul 11, 2024
@jeremyharisch jeremyharisch changed the title [Deletion Modes] Implement Logic to Extract and Insert Managed Resources into Manifest CR associatedResources [Deletion Modes] Implement Logic to Extract and Insert Associated Resources into Manifest CR associatedResources Jul 11, 2024
@ruanxin ruanxin closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants