Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deletion Modes] Introduce associatedResources field to Manifest Spec #1582

Closed
2 tasks done
nesmabadr opened this issue May 27, 2024 · 1 comment
Closed
2 tasks done
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nesmabadr
Copy link
Contributor

nesmabadr commented May 27, 2024

Description

In order to support #1211, we need to have the associatedResources saved in the ManifestSpec.

Reasons

To support managed resources, we need the associatedResources field so that it can be used to determine which resources are managed and need to be deleted first from the SKR Cluster.

Acceptance Criteria

  • Introduce optional AssociatedResources field to Manifest Spec
  • Add corresponding Documentation

Example Manifest CR:

[...]
spec:
  install:
    name: raw-manifest
    source:
      [...]
  remote: true
  resource:
    apiVersion: operator.kyma-project.io/v1alpha1
    kind: Sample
    metadata:
      name: sample-yaml
      namespace: kyma-system
    spec:
      resourceFilePath: ./module-data/yaml
  associatedResources: 
     - serverless.kyma-project.io/v1alpha2/functions
     - operator.kyma-project.io/v1alpha1/serverlesses
  version: 1.1.1

Feature Testing

No response

Testing approach

No response

Attachments

No response

@nesmabadr nesmabadr added the kind/feature Categorizes issue or PR as related to a new feature. label May 27, 2024
@nesmabadr nesmabadr self-assigned this Jul 1, 2024
@nesmabadr nesmabadr removed their assignment Jul 2, 2024
@nesmabadr nesmabadr changed the title [Deletion Modes] Introduce managedResources field to Manifest Spec [Deletion Modes] Introduce associatedResources field to Manifest Spec Jul 8, 2024
@nesmabadr
Copy link
Contributor Author

This field was reverted in this PR since it is no longer needed for the modules deletion feature

@nesmabadr nesmabadr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants