fix tests

kyma-project · Jan 24, 2025 · f4eb1a5 · f4eb1a5
1 parent 6c7ceb1
commit f4eb1a5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/tests/e2e/commontestutils/deployment.go b/tests/e2e/commontestutils/deployment.go
@@ -71,9 +71,6 @@ func GetDeployment(ctx context.Context, clnt client.Client,
 ) (*apiappsv1.Deployment, error) {
 	deploy := &apiappsv1.Deployment{}
 	if err := clnt.Get(ctx, client.ObjectKey{Name: name, Namespace: namespace}, deploy); err != nil {
-		if util.IsNotFound(err) {
-			return nil, testutils.ErrNotFound
-		}
 		return nil, fmt.Errorf("could not get deployment: %w", err)
 	}
 	return deploy, nil

diff --git a/tests/e2e/modulereleasemeta_maintenance_window_module_downtime_test.go b/tests/e2e/modulereleasemeta_maintenance_window_module_downtime_test.go
@@ -182,7 +182,7 @@ func disableModule(module *v1beta2.Module, kyma *v1beta2.Kyma) {
 		Should(Succeed())
 
 	By("Then Module Operator Deployment is removed")
-	Eventually(GetDeployment).
+	Eventually(DeploymentIsReady).
 		WithContext(ctx).
 		WithArguments(skrClient, ModuleDeploymentNameInNewerVersion, TestModuleResourceNamespace).
 		Should(Equal(ErrNotFound))
@@ -210,13 +210,13 @@ func flickKymaToFastChannel(moduleCR *unstructured.Unstructured,
 		Should(Succeed())
 
 	By("And old Module Operator Deployment still exists")
-	Consistently(DeploymentIsReady).
+	Eventually(DeploymentIsReady).
 		WithContext(ctx).
 		WithArguments(skrClient, ModuleDeploymentNameInOlderVersion, TestModuleResourceNamespace).
 		Should(Succeed())
 
 	By("And new Module Operator Deployment is not deployed")
-	Consistently(DeploymentIsReady).
+	Eventually(DeploymentIsReady).
 		WithContext(ctx).
 		WithArguments(skrClient, ModuleDeploymentNameInNewerVersion, TestModuleResourceNamespace).
 		Should(Equal(ErrNotFound))