Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate application connector tests #16692

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Migrate application connector tests #16692

merged 4 commits into from
Feb 15, 2023

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Jan 31, 2023 •
edited by koala7659
Loading

Removing all dependencies from application-connector component tests to deleted application-operator module and replacing them with dependencies to central-application-gateway used from now to handle application CRs

Related issue(s)
#16660

@netlify
Copy link

netlify bot commented Jan 31, 2023 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 49e94bf
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63e63a8b2a45b60008fee75e
😎 Deploy Preview https://deploy-preview-16692--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2023
@VOID404 VOID404 mentioned this pull request Jan 31, 2023
Merged
4 tasks
@kyma-project kyma-project deleted a comment from kyma-bot Feb 1, 2023
@kyma-project kyma-project deleted a comment from kyma-bot Feb 1, 2023
@VOID404
Copy link
Contributor Author

VOID404 commented Feb 2, 2023

/retest

@VOID404 VOID404 changed the title Migrate application connector tests [WIP] Migrate application connector tests Feb 3, 2023
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@Disper Disper mentioned this pull request Feb 3, 2023
Closed
franpog859
franpog859 previously approved these changes Feb 3, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 3, 2023
@VOID404
Copy link
Contributor Author

VOID404 commented Feb 10, 2023

/retest

@VOID404 VOID404 changed the title [WIP] Migrate application connector tests Migrate application connector tests Feb 10, 2023
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 10, 2023
@VOID404
Copy link
Contributor Author

VOID404 commented Feb 10, 2023

/retest

1 similar comment
@VOID404
Copy link
Contributor Author

VOID404 commented Feb 10, 2023

/retest

@kyma-project kyma-project deleted a comment from kyma-bot Feb 10, 2023
@VOID404
Copy link
Contributor Author

VOID404 commented Feb 10, 2023

/retest

1 similar comment
@VOID404
Copy link
Contributor Author

VOID404 commented Feb 10, 2023

/retest

@VOID404
Copy link
Contributor Author

VOID404 commented Feb 13, 2023

/retest

1 similar comment
@VOID404
Copy link
Contributor Author

VOID404 commented Feb 14, 2023

/retest

@kyma-bot
Copy link
Contributor

@VOID404: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-function-runtimes-nodejs18-build 6ec2ce2 link true /test pull-function-runtimes-nodejs18-build
pre-main-kyma-integration-k3d-runtime-agent 49e94bf link false /test pre-main-kyma-integration-k3d-runtime-agent

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@koala7659 koala7659 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2023
koala7659
koala7659 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one remark. Please remove empty PR description and replace with something meaningful.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 15, 2023
@koala7659 koala7659 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2023
@koala7659
Copy link
Contributor

/test tide

@kyma-bot
Copy link
Contributor

@koala7659: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test kyma-metadata-schema-governance
  • /test pre-kyma-artifacts
  • /test pre-kyma-tests-fast-integration-image
  • /test pre-kyma-validate-inrepo-prow-configs
  • /test pre-main-kyma-common
  • /test pre-main-kyma-eval-istio-integration-k3d
  • /test pre-main-kyma-gardener-gcp-eventing
  • /test pre-main-kyma-gardener-gcp-eventing-upgrade
  • /test pre-main-kyma-gardener-gcp-goats-api-gateway
  • /test pre-main-kyma-gke-external-registry
  • /test pre-main-kyma-governance
  • /test pre-main-kyma-integration-k3d
  • /test pre-main-kyma-integration-k3d-telemetry
  • /test pre-main-kyma-prod-istio-integration-k3d
  • /test pre-main-kyma-validate-dockerfiles
  • /test pre-main-serverless-integration-k3s
  • /test pull-central-application-connectivity-validator-build
  • /test pull-central-application-gateway-build
  • /test pull-compass-runtime-agent-build
  • /test pull-directory-size-exporter-build
  • /test pull-event-publisher-proxy-build
  • /test pull-event-publisher-proxy-lint
  • /test pull-event-publisher-proxy-unit-test
  • /test pull-eventing-controller-build
  • /test pull-eventing-controller-lint
  • /test pull-eventing-controller-unit-test
  • /test pull-function-controller-build
  • /test pull-function-controller-test-build
  • /test pull-function-java17-jvm-alpha-build
  • /test pull-function-jobinit-build
  • /test pull-function-runtimes-nodejs14-build
  • /test pull-function-runtimes-nodejs16-build
  • /test pull-function-runtimes-nodejs18-build
  • /test pull-function-runtimes-python39-build
  • /test pull-function-webhook-build
  • /test pull-kyma-pjconfigtest
  • /test pull-kyma-pjtester
  • /test pull-kyma-vpathguard
  • /test pull-telemetry-operator-build
  • /test pull-telemetry-operator-lint
  • /test pull-telemetry-operator-unit-test
  • /test pull-tests-serverless-bench-build
  • /test pull-webhook-cert-init-build

The following commands are available to trigger optional jobs:

  • /test pre-kyma-presubmit-scanner
  • /test pre-main-check-users-map
  • /test pre-main-kyma-api-gateway-integration-k3d
  • /test pre-main-kyma-gardener-azure-alpha-eval
  • /test pre-main-kyma-gardener-azure-alpha-prod
  • /test pre-main-kyma-gardener-azure-fast-integration
  • /test pre-main-kyma-gardener-gcp-eventing-v1alpha2
  • /test pre-main-kyma-gardener-gcp-subscription-upgrade
  • /test pre-main-kyma-integration-k3d-app-conn-validator
  • /test pre-main-kyma-integration-k3d-app-gateway
  • /test pre-main-kyma-integration-k3d-central-app-connectivity-compass
  • /test pre-main-kyma-integration-k3d-runtime-agent
  • /test pre-main-kyma-istio-reconcilation-k3d
  • /test pre-main-kyma-validate-image-definitions
  • /test pre-main-kyma-validate-image-existence
  • /test pull-application-connector-compass-runtime-agent-test-build
  • /test pull-application-connector-connectivity-validator-test-build
  • /test pull-application-connector-gateway-test-build
  • /test pull-application-connector-mock-app-build
  • /test pull-application-operator-lint
  • /test pull-application-operator-unit-test
  • /test pull-central-application-connectivity-validator-unit-test
  • /test pull-central-application-gateway-lint
  • /test pull-central-application-gateway-unit-test
  • /test pull-compass-runtime-agent-lint
  • /test pull-compass-runtime-agent-unit-test
  • /test pull-directory-size-exporter-lint
  • /test pull-directory-size-exporter-unit-test
  • /test pull-event-subscriber-tools-build
  • /test pull-function-controller-lint
  • /test pull-function-controller-unit-test
  • /test pull-function-registry-gc-build
  • /test pull-gitserver-build

Use /test all to run the following jobs that were automatically triggered:

  • pre-kyma-artifacts
  • pre-kyma-presubmit-scanner
  • pre-main-check-users-map
  • pre-main-kyma-integration-k3d-app-conn-validator
  • pre-main-kyma-integration-k3d-app-gateway
  • pre-main-kyma-integration-k3d-runtime-agent
  • pull-application-connector-compass-runtime-agent-test-build
  • pull-application-connector-connectivity-validator-test-build
  • pull-application-connector-gateway-test-build
  • pull-application-connector-mock-app-build

In response to this:

/test tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot merged commit 6af1bb3 into kyma-project:main Feb 15, 2023
@koala7659 koala7659 added this to the 2.12 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

@franpog859 franpog859 franpog859 left review comments

@akgalwas akgalwas Awaiting requested review from akgalwas

@mvshao mvshao Awaiting requested review from mvshao

Assignees

@koala7659 koala7659

@franpog859 franpog859

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
2.12
Development

Successfully merging this pull request may close these issues.
4 participants
@VOID404 @kyma-bot @koala7659 @franpog859