Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proxying test cases #14831

Merged
merged 11 commits into from
Jul 21, 2022
Merged

Implement proxying test cases #14831

merged 11 commits into from
Jul 21, 2022

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Jul 15, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Test response code proxying
  • Test body proxying
  • Test timeouts
  • Restructure HTTP client, to allow verifying bodies and other parts of response

Related issue(s)

#14654

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2022
@netlify
Copy link

netlify bot commented Jul 15, 2022 •
edited
Loading

✅ 🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit ad60dd0
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/62d8d997e2ad74000946ce4b
😎 Deploy Preview https://deploy-preview-14831--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@VOID404 VOID404 mentioned this pull request Jul 18, 2022
Closed
5 tasks
akgalwas
akgalwas previously approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@akgalwas akgalwas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 19, 2022
VOID404 added 7 commits July 19, 2022 16:39
@VOID404
Implement simple proxy cases
ca600ec 
They test response codes and bodies
@VOID404
Add timeout endpoint
34c4738
@VOID404
Add timeout test case
11360d8
@VOID404
Cleanup test placement
442ec1b
@VOID404
Return response body
bfb5666 
Now it's possible to log response bodies AND verify the content.
It's also possible to inspect whole responses in tests.
@VOID404
Move timeout to negative authorisation
ad30f32
@VOID404
Remove status verification from body tests
47057ac
@VOID404
Copy link
Contributor Author

VOID404 commented Jul 19, 2022

How should the central gateway handle weird codes, like 123? Should it crash? Should it just forward them?

@VOID404
Copy link
Contributor Author

VOID404 commented Jul 19, 2022

Timeout should probably return 504 Gateway Timeout , not 503 Service Unavailable

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 19, 2022
@VOID404 VOID404 marked this pull request as ready for review July 19, 2022 17:01
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2022
@VOID404 VOID404 requested a review from akgalwas July 19, 2022 17:03
akgalwas
akgalwas previously approved these changes Jul 20, 2022
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 20, 2022
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 21, 2022
@kyma-bot
Copy link
Contributor

@VOID404: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-integration-k3d-runtime-agent ad60dd0 link false /test pre-main-kyma-integration-k3d-runtime-agent
pre-main-kyma-integration-k3d-app-conn-validator ad60dd0 link false /test pre-main-kyma-integration-k3d-app-conn-validator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 21, 2022
@kyma-bot kyma-bot merged commit df311bc into kyma-project:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akgalwas akgalwas akgalwas approved these changes

@koala7659 koala7659 Awaiting requested review from koala7659

@janmedrek janmedrek Awaiting requested review from janmedrek

@franpog859 franpog859 Awaiting requested review from franpog859

@mvshao mvshao Awaiting requested review from mvshao

Assignees

@akgalwas akgalwas

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VOID404 @kyma-bot @akgalwas