Add the path-related test case to the App Gateway test suite #14762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs some chart cleanup. Test job will fail because it doesn't wait for test app to deploy.
Not yet finished!
Problem was caused by Istio
in Dockerfile
Https can't be used due to a bug in gateway
There is some regression in features and tests don't pass
Now makefile waits for pod to run, then displays logs and exits when tests are completed
This reverts commit 8ed62f3.
mvshao
added
area/application-connector
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
size/XXL
✅ 🥰 Documentation preview ready! 🥰
To edit notification comments on pull requests, go to your Netlify site settings. |
5 tasks
akgalwas
reviewed
Jul 7, 2022
| } | ||
| var actualCode, expectedCode int | ||
|
|
||
| switch service.Name { |
There was a problem hiding this comment.
The switch-case statement is redundant as the code for each case is identical.
| v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| func (gs *GatewaySuite) TestPath() { |
There was a problem hiding this comment.
Actually we don't need that code at all. Please, notice the following:
- The test cases description is contained within Application CRD
- The expected response code is contained within Application CRD
- Test cases checking positive authorisation are similar to path related ones in that sense that the Go code executing it is identical.
So there are two possibilities:
- Have one Application CRD with test cases for positive authorisation and path related cases
- Have a set of Go functions and a set of Application CRDs and combine them. We need the following code:
- Executing Get request and checking response code
- Executing Post request with body, additional query parameters and headers
- ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See the issue here - #14654