Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ConfigMap creation from Certificates components #11525

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Remove ConfigMap creation from Certificates components #11525

merged 1 commit into from
Jun 28, 2021

Conversation

mjakobczyk
Copy link
Contributor

Description

Changes proposed in this pull request:

  • remove ConfigMap creation from Certificates components in all scenarios

Related issue(s)

Fixes: kyma-project/hydroform#313

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2021
@piotrkpc
Copy link
Contributor

piotrkpc commented Jun 25, 2021 •
edited
Loading

-> kyma-project/hydroform#322 (comment)
/lgtm

@mjakobczyk mjakobczyk marked this pull request as ready for review June 25, 2021 13:13
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2021
@mjakobczyk mjakobczyk force-pushed the task/old-overrides-support-removal branch from f6a9daf to 32c7a4b Compare June 25, 2021 13:41
strekm
strekm approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@strekm strekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@kyma-bot
Copy link
Contributor

@strekm: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 28, 2021
@kyma-bot kyma-bot merged commit 72cb41e into kyma-project:main Jun 28, 2021
sankalp-r added a commit to sankalp-r/kyma that referenced this pull request Jun 28, 2021
@sankalp-r
Squashed commit of the following:
4381a79 
commit 3f462ad
Author: Christoph Kleineweber <[email protected]>
Date:   Mon Jun 28 13:12:44 2021 +0200

    Change cookie names for OAuth2 Proxy deployments (kyma-project#11566)

    To avoid problems with logging in to services that ran keycloak-proxy
    before.

commit 76b3a86
Author: Karol Szwaj <[email protected]>
Date:   Mon Jun 28 11:10:44 2021 +0200

    Update Istio to 1.10.2 (kyma-project#11562)

commit f601e1c
Author: Marco Bebway <[email protected]>
Date:   Mon Jun 28 10:10:44 2021 +0200

    Update Eventing resource limits for the evaluation profile (kyma-project#11551)

commit 72cb41e
Author: Michał Jakóbczyk <[email protected]>
Date:   Mon Jun 28 08:12:44 2021 +0200

    Remove ConfigMap creation from Certificates components (kyma-project#11525)

commit 3055a94
Author: Karol Szwaj <[email protected]>
Date:   Fri Jun 25 19:10:43 2021 +0200

    Update Istio-installer to 1.10.2 (kyma-project#11556)

commit 9fe2825
Author: ralikio <[email protected]>
Date:   Fri Jun 25 19:06:43 2021 +0200

    Corrected Runtime Agent Container Version (kyma-project#11555)

    * Corrected Agent Container Version

    * Correction

    Co-authored-by: Rafał Potempa <[email protected]>

    Co-authored-by: Rafał Potempa <[email protected]>

commit 650ff1e
Author: Tomasz Gorgol <[email protected]>
Date:   Fri Jun 25 18:08:43 2021 +0200

    Bump serverless images (kyma-project#11554)

commit 2d94fad
Author: Christoph Kleineweber <[email protected]>
Date:   Fri Jun 25 17:04:43 2021 +0200

    Replace keycloak-proxy by oauth2-proxy (kyma-project#11518)

    * Replace keycloak-proxy by oaht2-proxy for Grafana

    * Replace keycloak-proxy by oauth2-proxy for Kiali

    * Replace keycloak-proxy by oauth2-proxy for Jaeger

    * Update values for kcproxy to oauth2 proxy migration

    * Do not shop oauth2 proxy login page when using Dex

    * Adapt Dex redirect URLs for oauth2 proxy

    * Add oauth2 proxy overrides for fast integration test

    * Apply review comments

    * Update oauth2 proxy image tag

    * Disable request logging

commit dd7c314
Author: Andreas Thaler <[email protected]>
Date:   Fri Jun 25 16:04:43 2021 +0200

    istio tracing config is set to 100 (kyma-project#11549)

    * cleaning istio tracing config and setting a sampling rate of 100 for evaluation profile only

    * made sampling configurable at runtime via env variables

commit 0c95f2d
Author: Piotr Kopec <[email protected]>
Date:   Fri Jun 25 15:04:43 2021 +0200

    bump `apiserver-proxy` version (kyma-project#11553)

    Related: kyma-project#11533

commit d892771
Author: Piotr Kopec <[email protected]>
Date:   Fri Jun 25 14:04:43 2021 +0200

    remove `namespaces` dir because it's no longer needed (kyma-project#11529)

    After dropping support for namespace creation
    in preinstall this directory is no longer needed

    Resolves: kyma-project/hydroform#314

commit 3555ef0
Author: Patryk Strugacz <[email protected]>
Date:   Fri Jun 25 13:00:43 2021 +0200

    Use postgres 11.12 (kyma-project#11534)

commit 6129fc5
Author: Andreas Thaler <[email protected]>
Date:   Fri Jun 25 11:36:43 2021 +0200

    prepare kyma-gateway for kyma2 migration (kyma-project#11514)

commit 22eac25
Author: Andreas Thaler <[email protected]>
Date:   Thu Jun 24 17:42:42 2021 +0200

    updated base image kiali - fluent-bit, grafana patch update 7.4.5 (kyma-project#11542)

    * base image versions bumped

    * upgraded to grafana 7.4.5

commit 3e1e71e
Author: ralikio <[email protected]>
Date:   Thu Jun 24 15:38:46 2021 +0200

    Dependency Upgrade (kyma-project#11522)

    * Dependency Upgrade

    * Module Upgrades

commit ee0d95d
Author: Mohamed El Sayed <[email protected]>
Date:   Thu Jun 24 15:32:46 2021 +0200

    Fix nodejs build container (kyma-project#11536)

commit e3fa5f7
Author: Patryk Strugacz <[email protected]>
Date:   Thu Jun 24 14:12:46 2021 +0200

    Add jaegertracing crd (kyma-project#11532)

commit 1d087c9
Author: Michał Jakóbczyk <[email protected]>
Date:   Thu Jun 24 13:10:46 2021 +0200

    Remove cert-manager from Kyma (kyma-project#11442)

    * Remove cert-manager from Kyma

    * Include gitkeep in namespaces to maintain dir

    * Restore removed xip-patch job

    * Fix xip-patch job formatting

commit 9a2ecd1
Author: Piotr <[email protected]>
Date:   Thu Jun 24 12:10:46 2021 +0200

    Fix problem with duplicated keys (name label) (kyma-project#11528)

commit 120e9e0
Author: Karol Szwaj <[email protected]>
Date:   Thu Jun 24 11:12:46 2021 +0200

    Remove old Istio mutating webhook patches (kyma-project#11502)

commit e386863
Author: Michał Jakóbczyk <[email protected]>
Date:   Thu Jun 24 07:40:46 2021 +0200

    Perform cleanup for Impersonate-Group header in request (kyma-project#11533)

    * Perform cleanup for Impersonate-Group header in request

    * Perform header cleanup with Delete, add check to tests

    * Make malicious group a common var

    * Fix apiserver-proxy tests

commit 736dfd0
Author: Jan Wozniak <[email protected]>
Date:   Wed Jun 23 13:10:45 2021 +0200

    Bump helm-broker resource (kyma-project#11516)

commit 3fabb5f
Author: Krzysztof <[email protected]>
Date:   Tue Jun 22 12:38:45 2021 +0200

    Update default busola URL and enable pkce by default (kyma-project#11517)

    Co-authored-by: Kwiatosz, Krzysztof <[email protected]>

commit 42b1390
Author: Piotr <[email protected]>
Date:   Tue Jun 22 09:36:45 2021 +0200

    Remove duplicated keys in monitoring YAMLs (kyma-project#11515)
sayanh pushed a commit to sayanh/kyma that referenced this pull request Jul 6, 2021
@sayanh
Remove ConfigMap creation from Certificates components (kyma-project#…
2b1e468 
…11525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strekm strekm strekm approved these changes

@colunira colunira Awaiting requested review from colunira

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Awaiting requested review from Tomasz-Smelcerz-SAP

@werdes72 werdes72 Awaiting requested review from werdes72

Assignees

@strekm strekm

Labels
lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Parallel install] remove handling of old overrides
4 participants
@mjakobczyk @kyma-bot @piotrkpc @strekm