Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression Parsing with Antlr and Simple String Splitting #1703

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Jan 31, 2025

Description
Comparison between Antrl parser and simple string splitting to implement #1520.

Related issue(s)

1698

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Jan 31, 2025
@ralikio ralikio self-assigned this Jan 31, 2025
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 31, 2025
@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Feb 2, 2025
@ralikio ralikio changed the title Simple Expression Parsing with Antlr and Simple String Splitting Expression Parsing with Antlr and Simple String Splitting Feb 5, 2025
@PK85
Copy link

PK85 commented Feb 7, 2025

General comment about hap CLI version "0.0.5"

  • 1) Looks that generally parsing rules works, but found below issues:
    • 1.1) Search labels are not displayed
    • 1.2) Some errors for rules could be more specific, like: (we can fix//adjust that later)
      • 1.2.1) If wrong input attr, output attr, plan then suggest users what are correct possible values
      • 1.2.2) Position of the incorrect value is not specified
  • 2) Uniqueness check should:
    • 2.1) First step: filter out PR=* and HR=*
    • 2.2) Second step example: Rule1: aws(PR=abc) Rule2: aws(HR=efg) not allowed (take into account that if rule No3 will be aws(HR=efg, PR=abc) then this case that was not uniquee, has right now a Rule which eliminates ambiguity)
  • 3) When tool will support making request (with input PLAN PR HR) then I will test priority
  • 4) I added some new rule sets: https://github.com/PK85/hap-parser/tree/main/resources
    • 4.1) Please make them working as they are described in file names.
  • 5) We decided to not support antlr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants