Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Binding Docs Content #1454

Merged
merged 38 commits into from
Nov 19, 2024
Merged

Additional Binding Docs Content #1454

merged 38 commits into from
Nov 19, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Nov 14, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • added section for describing get, create and unbind bindings diagrams,
  • renamed bindings diagrams to keep assets folder conventions,
  • new "general overview" diagram.

Related issue(s)

#1357

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2024
@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Nov 15, 2024
@ralikio ralikio marked this pull request as ready for review November 15, 2024 10:37
@ralikio ralikio requested review from a team as code owners November 15, 2024 10:37
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) November 15, 2024 10:37
IwonaLanger
IwonaLanger reviewed Nov 15, 2024
View reviewed changes
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
@ralikio ralikio self-assigned this Nov 18, 2024
@kyma-project kyma-project deleted a comment from github-actions bot Nov 18, 2024
IwonaLanger
IwonaLanger reviewed Nov 19, 2024
View reviewed changes
docs/user/05-60-kyma-bindings-api-examples.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings-api-examples.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings-api-examples.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
docs/user/05-60-kyma-bindings.md Outdated Show resolved Hide resolved
IwonaLanger
IwonaLanger reviewed Nov 19, 2024
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
@ralikio @IwonaLanger
Update docs/README.md
1a9a10a 
Co-authored-by: Iwona Langer <[email protected]>
IwonaLanger
IwonaLanger previously approved these changes Nov 19, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 19, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 19, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit 0f175e8 into kyma-project:main Nov 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@ralikio ralikio

@IwonaLanger IwonaLanger

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ralikio @jaroslaw-pieszka @IwonaLanger @kyma-bot @kyma-gopher-bot