Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Gardener kubeconfig binding SKR tests #1319

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Remove Gardener kubeconfig binding SKR tests #1319

merged 8 commits into from
Oct 15, 2024

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Oct 15, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Remove Gardener kubeconfig path
  • Add more logs
  • Use more descriptive messages

Related issue(s)

See #1204

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Oct 15, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2024
@MarekMichali MarekMichali added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 15, 2024
@MarekMichali MarekMichali marked this pull request as ready for review October 15, 2024 14:33
@MarekMichali MarekMichali requested a review from a team as a code owner October 15, 2024 14:33
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 15, 2024 14:33
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 15, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit e9694ed into kyma-project:main Oct 15, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralikio ralikio ralikio approved these changes

Assignees

@ralikio ralikio

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarekMichali @ralikio @kyma-bot @kyma-gopher-bot