Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of Duplicated Accepts Incomplete & token_request Default Behaviour #1243

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Removal of Duplicated Accepts Incomplete & token_request Default Behaviour #1243

merged 4 commits into from
Oct 4, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Oct 2, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Removal of accepts_incomplete from the example request,
  • added explicit description of default value (false) for the token_request param.

Related issue(s)

#284

@ralikio ralikio requested a review from a team as a code owner October 2, 2024 10:47
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. labels Oct 2, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 2, 2024 10:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2024
@ralikio ralikio changed the title Removal of Accepts Incomplete & token_request Default Behaviour Removal of Duplicated Accepts Incomplete & token_request Default Behaviour Oct 3, 2024
@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 3, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 4, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 4, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit 9337680 into main Oct 4, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@MarekMichali MarekMichali MarekMichali approved these changes

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka left review comments

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@MarekMichali MarekMichali

@IwonaLanger IwonaLanger

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ralikio @jaroslaw-pieszka @MarekMichali @IwonaLanger @kyma-bot @kyma-gopher-bot