-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kyma Bindings Based on Token Requests - Create Endpoint #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Sep 17, 2024
Skipping CI for Draft Pull Request. |
Add one of following labels |
kyma-bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Sep 17, 2024
ralikio
changed the title
Kyma Bindings Based on Token Requests
Kyma Bindings Based on Token Requests - Create Endpoint
Sep 17, 2024
ralikio
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Sep 17, 2024
kyma-bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Sep 17, 2024
ralikio
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 18, 2024
MarekMichali
approved these changes
Sep 18, 2024
ralikio
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 18, 2024
/lgtm |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
Indicates the PR's author has signed the CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Looks good to me!
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR introduces generation of kubeconfig for Kyma Bindings (#284) in
/v2/service_instances/{instance_id}/service_bindings/{binding_id}
endpoint. Generated kubeconfig is returned under the credentials field in the API response. The kubeconfig is generated based on K8S TokenRequests.Changes proposed in this pull request:
BindingTokenExpirationSeconds
config to set up token expiration time,