Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kyma Bindings Based on Token Requests - Create Endpoint #1151

Merged
merged 11 commits into from
Sep 18, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Sep 17, 2024

Description

The following PR introduces generation of kubeconfig for Kyma Bindings (#284) in /v2/service_instances/{instance_id}/service_bindings/{binding_id} endpoint. Generated kubeconfig is returned under the credentials field in the API response. The kubeconfig is generated based on K8S TokenRequests.

Changes proposed in this pull request:

  • binding creation PUT endpoint implementation in bind_create.go,
  • BindingTokenExpirationSeconds config to set up token expiration time,
  • extended kubeconfig provider to provide a clientset client for k8s,
  • e2e test that checks cluster access by using generated kubeconfig.

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 17, 2024
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 17, 2024
@ralikio ralikio changed the title Kyma Bindings Based on Token Requests Kyma Bindings Based on Token Requests - Create Endpoint Sep 17, 2024
@ralikio ralikio added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 17, 2024
@ralikio ralikio marked this pull request as ready for review September 17, 2024 13:56
@ralikio ralikio requested a review from a team as a code owner September 17, 2024 13:56
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@ralikio ralikio added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 18, 2024
@ralikio ralikio removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 18, 2024
@MarekMichali
Copy link
Contributor

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 18, 2024
@kyma-bot kyma-bot merged commit 12a4062 into main Sep 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants