generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending Runtime Custom Resource with Additional Workers #601
Merged
kyma-bot
merged 20 commits into
kyma-project:main
from
koala7659:kim-additional-workers
Jan 28, 2025
Merged
Extending Runtime Custom Resource with Additional Workers #601
kyma-bot
merged 20 commits into
kyma-project:main
from
koala7659:kim-additional-workers
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m00g3n
reviewed
Jan 24, 2025
m00g3n
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to define and modify multiple workers for a Gardener shoot in the additionalWorkers collection
Description:
Changes proposed in this pull request:
additionalWorkers
collection - it will allow to define more worker groups in Gardener Shoot for Kyma RuntimeNewProviderExtenderPatchOperation
to patch Zones and version information for each Worker separately.InfrastructureConfig
andControlPlaneConfig
are treated as immutable during update unless they are specified in the RuntimeCRLogic flow operation update:
On shoot create:
additionalWorkers
collectionInfrastructureConfig
andcontrolPlaneConfig
are created to include ALL zones used in ALL provided workers .controlPlaneConfig
are provided inRuntimeCR
they will be used to create ShootinfrastructureConfig
zones cannot match with worker zones - the operation will failOn shoot update:
additionalWorkers
collection. This operation will not affect existinginfrastructureConfig
andcontrolPlaneConfig
InfrastructureConfig
andControlPlaneConfig
shoot data are immutableinfrastructureConfig
infrastructureConfig
andcontrolPlaneConfig
are provided inRuntimeCR
they will be used to create ShootinfrastructureConfig
zones cannot match with worker zones - the operation will failAdditional:
Related issue(s)
#46