Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compass Manager - implement watching Kyma custom resource #9

Closed
6 tasks done
akgalwas opened this issue May 18, 2023 · 3 comments
Closed
6 tasks done

Compass Manager - implement watching Kyma custom resource #9

akgalwas opened this issue May 18, 2023 · 3 comments
Assignees
@akgalwas
Labels
area/application-connector Issues or PRs related to application connectivity

Comments

@akgalwas
Copy link
Contributor

akgalwas commented May 18, 2023 •
edited
Loading

Implement reconciliation loop that watches Kyma custom resource.

Acceptance criteria:

  • Reconciliation is triggered only if one of the the following events occurs:
    • New Kyma CR created containing kubeconfig (Bring Your Own cluster scenario)
    • Kubeconfig field set on the existing Kyma CR
  • Reconciliation is not triggered if:
    • The last reconciliation attempt for particular Runtime succeeded (the Runtime is already registered in the Compass)
  • Functionality of registering Runtime in Compass, and creating Config Map for Compass Runtime Agent is mocked
    - [ ] If Kyma resource was removed, the Runtime must be unregistered.
@akgalwas akgalwas added the area/application-connector Issues or PRs related to application connectivity label May 18, 2023
@akgalwas akgalwas self-assigned this May 18, 2023
@mvshao mvshao assigned mvshao and unassigned akgalwas May 19, 2023
@mvshao mvshao mentioned this issue May 19, 2023
Merged
@akgalwas
Copy link
Contributor Author

akgalwas commented Jun 6, 2023

We should consider adding statuses on Kyma resource so that one could use kubectl describe to understand what is the state of Runtime.

kyma-bot added a commit that referenced this issue Jun 21, 2023
@kyma-bot
Watching for Kyma Custom Resource (#7)
ee54e54 
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**

Changes proposed in this pull request:

- implemented first version of `compass-manager`
- implemented logic for watching Kyma CR
- implemented event filter

**Related issue(s)**
#9
@akgalwas
Copy link
Contributor Author

Don't forget about those:

  • The conditions for triggering reconciliation loop can be simplified
  • Predicates used for checking if reconciliation loop should be triggered, can be tested with simple unit test. We tried to test it in ginkgo tests but it turn out to be less readable.

@pbochynski pbochynski mentioned this issue Jan 29, 2024
Open
@mvshao mvshao removed their assignment Jul 26, 2023
@mvshao mvshao mentioned this issue Jul 27, 2023
Closed
4 tasks
@akgalwas akgalwas changed the title Implement watching Kyma custom resource Compass Manager - Implement watching Kyma custom resource Sep 20, 2023
@akgalwas akgalwas changed the title Compass Manager - Implement watching Kyma custom resource Compass Manager - implement watching Kyma custom resource Sep 20, 2023
@akgalwas akgalwas mentioned this issue Sep 25, 2023
Merged
@akgalwas
Copy link
Contributor Author

Delete was moved to this issue #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akgalwas akgalwas

Labels
area/application-connector Issues or PRs related to application connectivity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akgalwas @mvshao