Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compass Manager - Implement creating Secret for Compass Runtime Agent #11

Closed
8 of 9 tasks
akgalwas opened this issue May 18, 2023 · 4 comments · Fixed by #43
Closed
8 of 9 tasks

Compass Manager - Implement creating Secret for Compass Runtime Agent #11

akgalwas opened this issue May 18, 2023 · 4 comments · Fixed by #43
Assignees
@koala7659 @mvshao
Labels
area/application-connector Issues or PRs related to application connectivity

Comments

@akgalwas
Copy link
Contributor

akgalwas commented May 18, 2023 •
edited by mvshao
Loading

Implement code that will create Secret for configuring Compass Runtime Agent.

Acceptance criteria:

  • KCP SyncResource lifecycle-manager#991 Proposal with unifying the way of inserting k8s objects from central components to customer SKR.
    After team disscusion -> For the first release of Compass Manager, we will not use this approach because it has not yet been implemented. Eventually, we will dispose our own Kubernetes client for SKR, and replace it with the central approach proposed in this issue.
  • When Runtime was successfully registered Compass Manager performs the following actions:
    • creates connection token that will be used by the Compass Runtime Agent.
    • creates Secret containing the following fields:
      • CONNECTOR_URL
      • TOKEN
      • RUNTIME_ID
      • TENANT
  • It must be assumed that Compass may be temporarily unavailable. We must provide resilience mechanisms, and eventual consistency.
@akgalwas akgalwas added the area/application-connector Issues or PRs related to application connectivity label May 18, 2023
@akgalwas akgalwas self-assigned this May 18, 2023
@pbochynski pbochynski mentioned this issue Jan 29, 2024
Open
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mvshao mvshao removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2023
@mvshao mvshao reopened this Jul 27, 2023
@akgalwas akgalwas changed the title Implement creating Config Map for Compass Runtime Agent Compass Manager - implement creating Config Map for Compass Runtime Agent Sep 20, 2023
@akgalwas akgalwas changed the title Compass Manager - implement creating Config Map for Compass Runtime Agent Compass Manager - Implement creating Config Map for Compass Runtime Agent Sep 20, 2023
@akgalwas akgalwas changed the title Compass Manager - Implement creating Config Map for Compass Runtime Agent Compass Manager - Implement creating Secret for Compass Runtime Agent Sep 20, 2023
@akgalwas
Copy link
Contributor Author

Consider using the same Integration System Provisioner uses

@mvshao mvshao assigned mvshao and unassigned akgalwas Nov 7, 2023
@mvshao mvshao mentioned this issue Nov 13, 2023
Merged
kyma-bot added a commit that referenced this issue Nov 22, 2023
@kyma-bot
Create Compass Runtime Agent secret on SKR (#43)
e4b4fa5 
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**

Changes proposed in this pull request:

- create `compass-agent-configuration` Secret on SKRs
- refreshing Director token and upsert `compass-agent-configuration`
Secret on SKRs

**Related issue(s)**
Closes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koala7659 koala7659

@mvshao mvshao

Labels
area/application-connector Issues or PRs related to application connectivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create Compass Runtime Agent secret on SKR mvshao/compass-manager
4 participants
@akgalwas @koala7659 @kyma-bot @mvshao