Skip to content

Commit

Permalink
code review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nesmabadr committed Dec 13, 2023
1 parent ea9de7e commit 8168efb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions cmd/kyma/alpha/deploy/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"time"

"github.com/kyma-project/lifecycle-manager/api/shared"
"github.com/kyma-project/lifecycle-manager/api/v1beta2"
"golang.org/x/exp/slices"

"github.com/spf13/cobra"
Expand Down Expand Up @@ -336,7 +337,7 @@ func (cmd *command) openDashboard(ctx context.Context) error {
kymas, err := cmd.K8s.Dynamic().Resource(
schema.GroupVersionResource{
Group: shared.OperatorGroup,
Version: "v1beta2",
Version: v1beta2.GroupVersion.Version,
Resource: shared.KymaKind.Plural(),
},
).List(ctx, v1.ListOptions{})
Expand Down Expand Up @@ -389,7 +390,7 @@ func (cmd *command) handleTimeoutErr(err error) error {
func (cmd *command) detectManagedKyma(ctx context.Context) error {
kymaResource := schema.GroupVersionResource{
Group: shared.OperatorGroup,
Version: "v1beta2",
Version: v1beta2.GroupVersion.Version,
Resource: shared.KymaKind.Plural(),
}

Expand Down
5 changes: 3 additions & 2 deletions cmd/kyma/alpha/list/module/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"time"

"github.com/kyma-project/lifecycle-manager/api/shared"
"github.com/kyma-project/lifecycle-manager/api/v1beta2"
"github.com/spf13/cobra"
"k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand All @@ -34,13 +35,13 @@ var moduleTemplates string

var moduleTemplateResource = schema.GroupVersionResource{
Group: shared.OperatorGroup,
Version: "v1beta2",
Version: v1beta2.GroupVersion.Version,
Resource: shared.ModuleTemplateKind.Plural(),
}

var kymaResource = schema.GroupVersionResource{
Group: shared.OperatorGroup,
Version: "v1beta2",
Version: v1beta2.GroupVersion.Version,
Resource: shared.KymaKind.Plural(),
}

Expand Down

0 comments on commit 8168efb

Please sign in to comment.