Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Toast is hidden behind Dialogs #3538

Merged
merged 5 commits into from
Dec 18, 2024
Merged

fix: Toast is hidden behind Dialogs #3538

merged 5 commits into from
Dec 18, 2024

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Dec 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • fixed Toast being hidden behind Dialogs

Related issue(s)
#3422

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Dec 16, 2024
@OliwiaGowor OliwiaGowor marked this pull request as ready for review December 16, 2024 07:22
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 16, 2024
@OliwiaGowor OliwiaGowor mentioned this pull request Dec 16, 2024
Open
@mrCherry97 mrCherry97 requested a review from a team as a code owner December 17, 2024 11:18
@mrCherry97 mrCherry97 force-pushed the ui5-migrate-v2 branch 2 times, most recently from e10b457 to 5b7fd61 Compare December 17, 2024 11:33
mrCherry97
mrCherry97 requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix PR history of the commits, after merge I made a mess and there is new UI5 migration PR

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@mrCherry97 mrCherry97 merged commit 764bf23 into kyma-project:ui5-migrate-v2 Dec 18, 2024
3 of 12 checks passed
OliwiaGowor added a commit to OliwiaGowor/busola that referenced this pull request Dec 20, 2024
@OliwiaGowor
fix: Toast is hidden behind Dialogs (kyma-project#3538)
7492c4a 
* Revert "Merge branch 'main' into ui5-migrate-v2"

This reverts commit 79fb867, reversing
changes made to 5b7fd61.

* fix: selected in lists (kyma-project#3539)

* fix: toasts in dialogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 requested changes

@akucharska akucharska akucharska approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@akucharska akucharska

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OliwiaGowor @akucharska @mrCherry97 @kyma-bot