Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Busola is flickering when ObjectPage is opened #3498

Merged
merged 16 commits into from
Dec 13, 2024
Merged

fix: Busola is flickering when ObjectPage is opened #3498

merged 16 commits into from
Dec 13, 2024

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Nov 25, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • adjusted DynamicPageComponent and GenericList

Related issue(s)
#3422

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2024
@OliwiaGowor OliwiaGowor marked this pull request as ready for review November 25, 2024 15:07
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2024
mrCherry97
mrCherry97 requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to replace DynamicPage with ObjectPage, because it's jumping a lot.

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2024
@mrCherry97 mrCherry97 removed their assignment Dec 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2024
@OliwiaGowor OliwiaGowor merged commit 5b7fd61 into kyma-project:ui5-migrate-v2 Dec 13, 2024
6 of 13 checks passed
@OliwiaGowor OliwiaGowor mentioned this pull request Dec 16, 2024
Open
OliwiaGowor added a commit to OliwiaGowor/busola that referenced this pull request Dec 20, 2024
@OliwiaGowor @mrCherry97 @akucharska
fix: Busola is flickering when ObjectPage is opened (kyma-project#3498)
d498798 
* fix: fix flickering on column layout

* fix: remove unused

* fix: replace DynamicPage with ObjectPage

* fix: fix key error

* fix: banner height and remove unused

* fix: initial render flicker

* fix: change to DynamicPage

* hotfix

* Replace props spread

* hotfix

* fix: shadow & unused

* fix: shadow & sticky tabs

* fix: hide button everywhere

---------

Co-authored-by: mrCherry97 <[email protected]>
Co-authored-by: akucharska <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 requested changes

@akucharska akucharska akucharska approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@akucharska akucharska

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OliwiaGowor @akucharska @mrCherry97 @kyma-bot